Skip to content
This repository was archived by the owner on Sep 30, 2022. It is now read-only.

Topic/v1.10/mpi win create dynamic #711

Merged
rhc54 merged 6 commits into from
Oct 26, 2015
Merged

Topic/v1.10/mpi win create dynamic #711

rhc54 merged 6 commits into from
Oct 26, 2015

Conversation

@ggouaillardet
Copy link
Contributor

@ggouaillardet ggouaillardet commented Oct 23, 2015

Add missing Fortran bindings for

  • MPI_Win_attach
  • MPI_Win_detach
  • MPI_Win_create_dynamic

@mellanox-github
Copy link

mellanox-github commented Oct 23, 2015

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-v1.8-pr/915/ for details.

@ggouaillardet
Copy link
Contributor Author

ggouaillardet commented Oct 23, 2015

:bot:milestone:v1.10.1
:bot🏷️enhancement
:bot🏷️bug
:bot🏷️ @jsquyres

@ompiteam-bot ompiteam-bot added this to the v1.10.1 milestone Oct 23, 2015
jsquyres
jsquyres reviewed Oct 23, 2015
View reviewed changes
ompi/mpi/fortran/use-mpi-f08/mpi-f-interfaces-bind.h
Copy link
Member

@jsquyres jsquyres Oct 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need this MPI_ADDRESS_KIND

@jsquyres
Copy link
Member

jsquyres commented Oct 23, 2015

Looks like the same small number of errors just got copy-n-pasted all the way through. Should be easy to fix.

Thanks @ggouaillardet!

@ggouaillardet
MPI_Win_create_dynamic : add Fortran bindings
bbd4a2d 
(cherry picked from commit open-mpi/ompi@f45244d)
@ggouaillardet
MPI_Win_Create_dynamic: add missing files
a84ecb9 
fixes commit open-mpi/ompi@f45244d

(back ported from commit 1d8ce96)
@ggouaillardet
MPI_Win_{attach,detach} : add Fortran bindings
29e7198 
(cherry picked from commit open-mpi/ompi@9600e2b)
@ggouaillardet
MPI_Win_{attach,detach}: add missing files
c73541a 
fixes commit open-mpi/ompi@9600e2b

(back ported from commit open-mpi/ompi@7179d44)
@ggouaillardet
mpi_f08: fix MPI_WIN_{ATTACH,DETACH} bindings
20cc09e 
fixes INTENT from open-mpi/ompi@9600e2b

(cherry picked from commit open-mpi/ompi@13950c3)
@ggouaillardet
mpi_f08: fix MPI_WIN_{ATTACH,DETACH} bindings
4c01d49 
fixes INTENT from open-mpi/ompi@9600e2b

Thanks Jeff for pointing this !

(cherry picked from commit open-mpi/ompi@1105634)
@ggouaillardet ggouaillardet force-pushed the topic/v1.10/mpi_win_create_dynamic branch from 4750a44 to 4c01d49 Compare October 26, 2015 01:05
@ggouaillardet
Copy link
Contributor Author

ggouaillardet commented Oct 26, 2015

@jsquyres one commit was not cherry-picked from master.
i fixed more stuff in the master and cherry-picked into this PR.
if i remove

   use :: mpi_f08_types, only : MPI_ADDRESS_KIND

compilation fails

@ggouaillardet
Copy link
Contributor Author

ggouaillardet commented Oct 26, 2015

:bot:nolabel:pushed-back

@mellanox-github
Copy link

mellanox-github commented Oct 26, 2015

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-v1.8-pr/925/ for details.

@ggouaillardet
Copy link
Contributor Author

ggouaillardet commented Oct 26, 2015

:bot🏷️blocker

@jsquyres some mtt tests do not even build without this PR, so i just marked this as a blocker

@jsquyres
Copy link
Member

jsquyres commented Oct 26, 2015

Gilles - thanks for digging in to it. 👍

rhc54 pushed a commit that referenced this pull request Oct 26, 2015
Merge pull request #711 from ggouaillardet/topic/v1.10/mpi_win_create…
8d79547 
…_dynamic

Topic/v1.10/mpi win create dynamic
@rhc54 rhc54 merged commit 8d79547 into open-mpi:v1.10 Oct 26, 2015
alinask pushed a commit to alinask/ompi-release that referenced this pull request Dec 10, 2015
@jsquyres
Merge pull request open-mpi#711 from jsquyres/pr/possible-sles-rpm-li…
7224784 
…nker-fix

fortran: link the opal-pal.la library directly
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@jsquyres jsquyres

Labels

blocker bug enhancement reviewed RM-Approved

Projects

None yet

Milestone

v1.10.1

Development

Successfully merging this pull request may close these issues.

5 participants

@ggouaillardet @mellanox-github @jsquyres @rhc54 @ompiteam-bot