Skip to content

Releasing the list items when list destructor is called #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2015
Merged

Releasing the list items when list destructor is called #1004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7579ae3
Releasing the list items when list destructor is called
rppendya Oct 9, 2015
720fa86
changing the destruct function of list release API to release list …
rppendya Oct 20, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions opal/class/opal_list.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,17 @@ static void opal_list_construct(opal_list_t *list)


/*
* Reset all the pointers to be NULL -- do not actually destroy
* anything.
* Release the list items in the list.
* Reset list pointers to be NULL
*/
static void opal_list_destruct(opal_list_t *list)
{
opal_list_item_t *it;

while (NULL != (it = opal_list_remove_first(list))) {
OBJ_RELEASE(it);
}

opal_list_construct(list);
}

Expand Down
5 changes: 5 additions & 0 deletions oshmem/mca/memheap/base/memheap_base_mkey.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,6 +482,11 @@ void memheap_oob_destruct(void)
MPI_Request_free(&r->recv_req);
}

/*clear these list object as they don't belong here */
while (NULL != opal_list_remove_first(&memheap_oob.req_list)) {
continue;
}

OBJ_DESTRUCT(&memheap_oob.req_list);
OBJ_DESTRUCT(&memheap_oob.lck);
OBJ_DESTRUCT(&memheap_oob.cond);
Expand Down