v5.0.x: remove libompitrace #10054
Merged
v5.0.x: remove libompitrace #10054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure to check for MPI_DATATYPE_NULL before calling PMPI_Type_get_name(). As of MPI-4.0, there's still at least some disagreement as to whether MPI_DATATYPE_NULL is a valid input parameter for MPI_TYPE_GET_NAME. While that discussion is ongoing, fix up libompitrace to do what is guaranteed to work. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit f650d3c)
This small library was added for a specific purpose several years ago. There is no longer a maintainer for this library, and it hasn't been documented for years (and therefore there are likely very few -- if any -- users). We're therefore removing libompitrace from future versions of Open MPI; it can be obtained from prior version of Open MPI if it is desired. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit 0f51406)
bwbarrett
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the cherry-pick clean, I cherry-picked two commits from master:
The net is to fully remove libompitrace.
Refs #10036