pml/ob1: Add dtoh copy progress engine #10852
Conversation
Signed-off-by: William Zhang <wilzhang@amazon.com>
|
Could you provide a bit more information in the commit message about what this is? E.g., what's "dtoh"? |
| OPAL_THREAD_LOCK(&pml_ob1_accelerator_dtoh_lock); | ||
| if (accelerator_event_dtoh_num_used == accelerator_event_max) { | ||
| opal_output_verbose(1, mca_pml_ob1_output, "Out of event handles. Max: %d. Suggested to rerun with new max with mca mpi_common_accelerator_event_max %d.", | ||
| accelerator_event_max, accelerator_event_max + 100); |
There was a problem hiding this comment.
Missing unlock before the return here
| int result; | ||
|
|
||
| if (0 == strcmp(accelerator_base_selected_component.base_version.mca_component_name, "null")) { | ||
| return 0; |
There was a problem hiding this comment.
Should that be OPAL_SUCCESS?
| int result; | ||
|
|
||
| if (0 == strcmp(accelerator_base_selected_component.base_version.mca_component_name, "null")) { | ||
| return 0; |
There was a problem hiding this comment.
Shoulld that be OPAL_SUCCESS? I wonder if the return values should be OMPI_* variants in this component...
| "Accelerator event query returned OPAL_ERR_RESOURCE_BUSY"); | ||
| *frag = NULL; | ||
| OPAL_THREAD_UNLOCK(&pml_ob1_accelerator_dtoh_lock); | ||
| return 0; |
There was a problem hiding this comment.
What does zero mean here? OPAL_SUCCESS? See also below
It's about the direction of the operation, from the source to the destination location. Thus, |
4 participants
Signed-off-by: William Zhang wilzhang@amazon.com