Add support for gcc13 to 5.x #12267
Merged
Add support for gcc13 to 5.x #12267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only way to get IOV_MAX (and friends) is to manually include the GCC specific syslimits.h header (sys/syslimits.h would not work either). Fixes open-mpi#12110 Signed-off-by: George Bosilca <bosilca@icl.utk.edu> (cherry picked from commit bbc317f)
Manually define it based on the length of the ssize_t type. Fixes open-mpi#12109 Signed-off-by: George Bosilca <bosilca@icl.utk.edu> (cherry picked from commit fbea826)
Instead rely on OPAL_PATH_MAX #define. This complements the fix for open-mpi#12108 Signed-off-by: George Bosilca <bosilca@icl.utk.edu> (cherry picked from commit e051834)
We need to discover the existence and then include sys/param.h while using the correctly named MPL defines. Fixes open-mpi#12108 Signed-off-by: George Bosilca <bosilca@icl.utk.edu> (cherry picked from commit 9347a55)
jsquyres
approved these changes
Jan 23, 2024
@janjust NV CI is down again - could you help with this? I will run AWS internal CI in the meantime. |
|
AWS internal CI passed. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12110, #12109, #12108