Skip to content

Conversation

@wenduwan
Copy link
Contributor

@wenduwan wenduwan commented Mar 6, 2024

Running tests....

bot:notacherrypick

Signed-off-by: Wenduo Wang <wenduwan@amazon.com>
@wenduwan wenduwan self-assigned this Mar 6, 2024
@wenduwan wenduwan marked this pull request as draft March 6, 2024 22:07
@github-actions github-actions bot added this to the v5.0.3 milestone Mar 6, 2024
@wenduwan
Copy link
Contributor Author

wenduwan commented Mar 7, 2024

@rhc54 I'm still seeing the compiler warning(now it's an error) in pmix v5.0. Thoughts?

2024-03-06 22:34:02,968 - INFO - utils - Executing command: ./configure --with-sge --without-verbs --with-libfabric=/opt/amazon/efa --disable-man-pages --enable-ipv6 LDFLAGS=-Wl,--as-needed --enable-prte-prefix-by-default --enable-mca-dso=all --with-libevent=external --with-hwloc=external --with-cuda=/usr/local/cuda --with-cuda-libdir=/usr/local/cuda/lib64/stubs --enable-debug
2024-03-06 22:35:15,846 - INFO - utils - Executing command: make -j
2024-03-06 22:35:24,781 - ERROR - utils - Command make -j failed with error:
Makefile:1684: warning: overriding recipe for target `check-recursive'
Makefile:1406: warning: ignoring old recipe for target `check-recursive'
hwloc/pmix_hwloc.c: In function ‘pmix_hwloc_setup_topology’:
hwloc/pmix_hwloc.c:355:1: error: label ‘tryv1’ defined but not used [-Werror=unused-label]
 tryv1:
 ^~~~~
hwloc/pmix_hwloc.c: In function ‘set_flags’:
hwloc/pmix_hwloc.c:1407:5: error: "HWLOC_VERSION_MAJOR" is not defined, evaluates to 0 [-Werror=undef]
 #if HWLOC_VERSION_MAJOR > 2
     ^~~~~~~~~~~~~~~~~~~
hwloc/pmix_hwloc.c:1409:7: error: "HWLOC_VERSION_MAJOR" is not defined, evaluates to 0 [-Werror=undef]
 #elif HWLOC_VERSION_MAJOR == 2 && HWLOC_VERSION_MINOR >= 1
       ^~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[4]: *** [hwloc/pmix_hwloc.lo] Error 1
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [all-recursive] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all-recursive] Error 1

bot:notacherrypick

Signed-off-by: Wenduo Wang <wenduwan@amazon.com>
@wenduwan wenduwan force-pushed the v5.0.x_bump_submodules branch from 642a406 to 34bd015 Compare March 7, 2024 01:38
@wenduwan
Copy link
Contributor Author

wenduwan commented Mar 7, 2024

@rhc54 I figured I didn't get latest commits. Running tests again.

@rhc54
Copy link
Contributor

rhc54 commented Mar 7, 2024

The fix went to PMIx v5.0 branch 3 weeks ago.

@wenduwan
Copy link
Contributor Author

Passed AWS CI

@wenduwan wenduwan marked this pull request as ready for review March 11, 2024 15:09
@wenduwan wenduwan requested a review from janjust March 11, 2024 15:09
@janjust janjust merged commit c0f98b8 into open-mpi:v5.0.x Mar 11, 2024
@wenduwan wenduwan deleted the v5.0.x_bump_submodules branch March 26, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants