basic implementation of MPI_TYPE_GET_VALUE_INDEX #13364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only support named types with this first pass. related to open-mpi#12076 Fortran interfaces will be added once Fortran infrastructure additions in PR open-mpi#13279 are merged in to main. Signed-off-by: Howard Pritchard <howardp@lanl.gov>
Signed-off-by: Howard Pritchard <howardp@lanl.gov>
|
bot:ompi:retest |
|
@edgargabriel could you review this when you have a chance? |
edgargabriel
previously approved these changes
Sep 3, 2025
ompi/datatype/ompi_datatype_create.c
Outdated
| } else if (value_type->id == OMPI_DATATYPE_MPI_LONG_DOUBLE) { | ||
| *pair_type = (ompi_datatype_t *)&ompi_mpi_longdbl_int; | ||
| } else { | ||
| *pair_type = (ompi_datatype_t *)&ompi_mpi_datatype_null; |
There was a problem hiding this comment.
minor: it might be easier to initialize *pair_type to ompi_datatype_null at the beginning of the routine, and avoid the else parts in the code in multiple locations.
There was a problem hiding this comment.
good idea. i'll push a change and squash.
devreal
reviewed
Sep 3, 2025
ompi/mpi/fortran/mpif-h/Makefile.am
Outdated
| type_get_name_f.c \ | ||
| type_get_true_extent_f.c \ | ||
| type_get_true_extent_x_f.c \ | ||
| type_get_value_index_f.c \ |
There was a problem hiding this comment.
Nit pick: indentation seems off here
| ptype_get_name_f.c \ | ||
| ptype_get_true_extent_f.c \ | ||
| ptype_get_true_extent_x_f.c \ | ||
| ptype_get_value_index_f.c \ |
There was a problem hiding this comment.
Nit pick: indentation seems off here
Signed-off-by: Howard Pritchard <howardp@lanl.gov>
|
@edgargabriel please check again |
edgargabriel
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only support named types with this first pass.
related to #12076
Fortran interfaces will be added once Fortran infrastructure additions in PR #13279 are merged in to main.