type_hindexed: fix compiler warnings #1523
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically:
adio/common/utils.c: In function ‘ADIOI_Type_create_hindexed_x’:
adio/common/utils.c:97:3: warning: passing argument 3 of
‘PMPI_Type_hindexed’ discards ‘const’ qualifier from pointer target
type [-Wdiscarded-qualifiers]
Signed-off-by: Karol Mroz <mroz.karol@gmail.com>
|
As nice as this is I don't think we can take it. The MPI_Type_hindexed call was deprecated and did not get the const keyword. A better fix would be to patch romio to not use the deprecated routine. @jsquyres am I wrong? |
|
s/deprecated/removed/ since MPI 3.0 (source MPI 3.1 page 18 line 17). |
|
Ahhh, I see. Then definitely replacing the calls is the way to go 😄 Will close this for now. |
ghost
closed this
ghost
deleted the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically:
adio/common/utils.c: In function ‘ADIOI_Type_create_hindexed_x’:
adio/common/utils.c:97:3: warning: passing argument 3 of
‘PMPI_Type_hindexed’ discards ‘const’ qualifier from pointer target
type [-Wdiscarded-qualifiers]
Signed-off-by: Karol Mroz mroz.karol@gmail.com