debuggers: remove some useless code #1640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MPIR-1.0 specifies that the following symbols are only relevant in the starter process: - MPIR_Breakpoint - MPIR_being_debugged - MPIR_debug_state - MPIR_debug_abort_string I.e., the code filling in values in these various symbols was useless / never used. MPIR-1.1 will define that MPIR_being_debugged *is* relevant in MPI processes. That symbol is currently defined in libopen-rte (which is currently causing a duplicate symbol error for static builds -- this commit fixes that error), and is therefore still available for MPI processes. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MPIR-1.0 specifies that the following symbols are only relevant in the starter process:
I.e., the code filling in values in these various symbols was useless / never used.
MPIR-1.1 will define that MPIR_being_debugged is relevant in MPI processes. That symbol is currently defined in libopen-rte (which is currently causing a duplicate symbol error for static builds -- this commit fixes that error), and is therefore still available for MPI processes.
Signed-off-by: Jeff Squyres jsquyres@cisco.com
@bosilca @rhc54 Please review.