bml/r2: be more restrictive on rdma endpoints #1832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes bml/r2 more restrictive on which endpoints end up in the rdma endpoint list. Before this commit an endpoint was added if it supported either put or get. This was done to ensure that endpoints are available for RMA. Thought it is possible to support put or get endpoints we only currently support endpoints that have put, get, and amos. bml/r2 now reflects this support. Signed-off-by: Nathan Hjelm <hjelmn@me.com>
Member
Author
|
This might have an impact on #1831. @jladd-mlnx Let me know if that is the case. |
Member
Author
|
The intent is to support RMA over btls when only some true RMA operations are supported by the btl. As this support is not ready this PR is fine for now. If I finish the intended RMA support we will need to figure out how to prevent ob1 from using a btl it was not supposed to use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes bml/r2 more restrictive on which endpoints end up in the rdma
endpoint list. Before this commit an endpoint was added if it supported either
put or get. This was done to ensure that endpoints are available for RMA.
Thought it is possible to support put or get endpoints we only currently
support endpoints that have put, get, and amos. bml/r2 now reflects this
support.
Signed-off-by: Nathan Hjelm hjelmn@me.com