v2.x: usnic queue fixes #2696
Merged
v2.x: usnic queue fixes #2696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquyres
force-pushed
the
pr/v2.x/usnic-queue-fixes
branch
from
9726b98 to
bfc982f
Compare
- Add more explanatory comments - Trivial whitespace / style updates - Rename opal_btl_usnic_force_retrans() -> opal_btl_usnic_fast_retrans() Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit 40fe575)
The types are technically typedef equivalent, but it's less confusing to use the types that agree with the name of the constructor. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit e25b860)
Since the usnic BTL is single-threaded in this area, there really is no danger, but don't use one of the pointers hanging off the frag after we return it to the freelist. Instead, save the endpoint pointer before returning the frag. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit b02d8c4)
The libfabric usnic provider may give you back TX/RX queues that are longer than you asked for. So just use the TX/RQ/CQ lengths that we asked for, regardless of what length comes back. Additionally, keep the length of the priority channel CQ separate from the length of the data CQ. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit 7787dad)
Don't just blindly send ACKs; ensure that we have send credits before doing so. If we don't have any send credits, just don't send the ACK (it'll come again soon enough; it's not a tragedy if we don't send it now). Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit 879d25e)
Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit c4d7876)
Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit 53dc75a)
Double check the queue lengths that we get back from libfabric to ensure that they are at least as long as we need. They *should* never be shorter than we need, but let's just check to be sure. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit bd5b8ed)
Show the actual RX/TX and CQ length returned by libfabric in verbose output. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit 2d28ccb)
Add some run-time assert checks for debug builds. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit 7048ade)
Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit 1fdd0fe)
Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit 706f53b)
jsquyres
force-pushed
the
pr/v2.x/usnic-queue-fixes
branch
from
bfc982f to
dcbe7a0
Compare
|
@bturrubiates Updated to include fixes from review of #2692. |
bturrubiates
approved these changes
Jan 10, 2017
|
@hppritcha Good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the v2.x version of master PR #2692.
It includes all but the last commit from #2692 (i.e., the one that change the output format of statistics).
This is a blocker because it fixes some usnic bugs when running at scale.