Skip to content

ras/tm: Fix !orte_keep_fqdn_hostnames for TORQUE #3228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2017
Merged

ras/tm: Fix !orte_keep_fqdn_hostnames for TORQUE #3228

merged 1 commit into from
Mar 24, 2017
+8 −0

Conversation

@jjhursey
Copy link
Member

Related to Issue #2328 and PR #2388

@jjhursey
ras/tm: Fix !orte_keep_fqdn_hostnames for TORQUE
5f28d85 
Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
(cherry picked from commit 9643175)
@jjhursey jjhursey added the bug label Mar 23, 2017
@jjhursey jjhursey added this to the v2.0.3 milestone Mar 23, 2017
@jjhursey jjhursey requested a review from rhc54 March 23, 2017 14:20
rhc54
rhc54 approved these changes Mar 23, 2017
View reviewed changes
Copy link
Contributor

@rhc54 rhc54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to document: this works only because tm_spawn uses launch id's (the index of the node entry in the PBS_NODEFILE) instead of hostnames. If it did use hostnames, then stripping them would cause Torque to not recognize the name.

@hppritcha hppritcha merged commit fbd1510 into open-mpi:v2.0.x Mar 24, 2017
@jjhursey jjhursey deleted the fix/v2.0.x/rm-short-hostname branch March 24, 2017 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhc54 rhc54 rhc54 approved these changes

Assignees

@rhc54 rhc54

Labels

bug RM approved

Projects

None yet

Milestone

v2.0.3

Development

Successfully merging this pull request may close these issues.

3 participants

@jjhursey @rhc54 @hppritcha