Fix segfault in TCP/BTL #3238
Merged
Fix segfault in TCP/BTL #3238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing it to inet_nop, and don't be quite as fancy with the pointer arithmetic as the combination was causing us to segfault every time this debug message was called. Signed-off-by: Ralph Castain <rhc@open-mpi.org> (cherry picked from commit 470452c)
|
We have special functions for checking the family. I had a patch but I can't find it right now, give me a moment to redo it. |
|
@bosilca any luck with your patch? (4 days == 1 moment ;) ) |
|
@bosilca any luck finding the patch? |
|
@bosilca Ping! |
|
I vote for merging this as is. |
|
@jsquyres go ahead and review and we'll merge if its okay with you. |
jsquyres
approved these changes
Apr 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly check the sa_family and cast the data correctly before passing it to inet_nop, and don't be quite as fancy with the pointer arithmetic as the combination was causing us to segfault every time this debug message was called.
Signed-off-by: Ralph Castain rhc@open-mpi.org
(cherry picked from commit 470452c)