v2.0.x: dl/dlopen: add libs to wrapper LIBS #3362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this, libs (e.g., "-ldl") are not added to the wrapper LIBS flags. This may work on some platforms, but on at least RHEL 7.3, it does not (i.e., compiling MPI applications fails because it can't find dlopen). Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit a054361)
rhc54
approved these changes
May 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, libs (e.g., "-ldl") are not added to the wrapper LIBS
flags. This may work on some platforms, but on at least RHEL 7.3, it
does not (i.e., compiling MPI applications fails because it can't find
dlopen).
Signed-off-by: Jeff Squyres jsquyres@cisco.com
(cherry picked from commit a054361)
@rhc54 please review