Topic/datatype (#3441)

[bosilca]

• Don't overflow the internal datatype count.
  Change the type of the count to be a size_t (it does not alter the total
  size of the internal structures, so has no impact on the ABI).

Signed-off-by: George Bosilca bosilca@icl.utk.edu

• Optimize the datatype creation.
  The internal array of counts of predefined types is now only created
  when needed, which is either in a heterogeneous environment, or when
  one call get_elements. It saves space and makes the convertor creation a
  little faster in some cases.

Rearrange the fields in the datatype description structs.

The macro OPAL_DATATYPE_INIT_PTYPES_ARRAY had a bug, and the
static array was only partially created. All predefined types should
have the ptypes array created and initialized.

Signed-off-by: George Bosilca bosilca@icl.utk.edu

• Fix the boundary computation.

Signed-off-by: George Bosilca bosilca@icl.utk.edu

• test/datatype: add test for short unpack on heteregeneous cluster

Signed-off-by: Gilles Gouaillardet gilles@rist.or.jp
Signed-off-by: George Bosilca bosilca@icl.utk.edu

• Trying to reduce the cost of creating a convertor.

Signed-off-by: George Bosilca bosilca@icl.utk.edu

• Respect the unpack boundaries.
  As Gilles suggested on opal_unpack_general_function might upack too much data #2535 the opal_unpack_general_function was
  unpacking based on the requested count and not on the amount of packed
  data provided.
  Fixes opal_unpack_general_function might upack too much data #2535.

Signed-off-by: George Bosilca bosilca@icl.utk.edu

[jjhursey]

PGI CI failure is an internal problem - should be fixed soon.

[jjhursey]

bot:ibm:pgi:retest

[ggouaillardet]

@bosilca this will require #3526 (or a different fix) for #3522

[bwbarrett]

bot:ompi:retest

[bwbarrett]

bot:ompi:retest

Looks like it failed due to the ARM build server crashing

[bwbarrett]

Per @bosilca, killing this off in favor of (the now merged) #3568