Stop all progress threads prior to releasing the peer objects to avoi… #3796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d a race condition whereby a lost connection could be reported after a peer object was freed and before the threads were stopped. Signed-off-by: Ralph Castain <rhc@open-mpi.org> (cherry picked from commit 85f8eb4)
hppritcha
approved these changes
Jun 30, 2017
Member
|
I did some more checking and it seems that the IBM tests that were doing spawn or connect/accept triggered the heap corruption problem in mpirun. This PR fixed that problem - at least when using the OB1 and CM PMLs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d a race condition whereby a lost connection could be reported after a peer object was freed and before the threads were stopped.
Signed-off-by: Ralph Castain rhc@open-mpi.org
(cherry picked from commit 85f8eb4)