Skip to content

pmix: fixed immediate request #3978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2017
Merged

pmix: fixed immediate request #3978

merged 1 commit into from
Jul 28, 2017

Conversation

@karasevb
Copy link
Member

@karasevb karasevb commented Jul 28, 2017

This commit fixes a hang when using external PMIx v1 module

Signed-off-by: Boris Karasev karasev.b@gmail.com

refs #3977

@karasevb
pmix: fixed immediate request
e20b581 
This commit fixes a hang when using external PMIx v1 module

Signed-off-by: Boris Karasev <karasev.b@gmail.com>
@karasevb karasevb added the bug label Jul 28, 2017
@karasevb karasevb requested review from artpol84 and rhc54 July 28, 2017 09:59
@karasevb karasevb mentioned this pull request Jul 28, 2017
Merged
@artpol84
Copy link
Contributor

artpol84 commented Jul 28, 2017

@karasevb
So this is only for a singletons?

@karasevb
Copy link
Member Author

karasevb commented Jul 28, 2017

@artpol84 Not only for singletons. Also problem has existed for multi ranks.

@artpol84
Copy link
Contributor

artpol84 commented Jul 28, 2017

Need another PR for that?

@karasevb
Copy link
Member Author

karasevb commented Jul 28, 2017

@artpol84
No. This fix targeting to both cases. There are two fixes, one of them fixes the optional request for only singleton, and second fixes the info-key for the immediate request that leads to hang for both cases (for single and multi ranks).

@jladd-mlnx jladd-mlnx added this to the v3.0.0 milestone Jul 28, 2017
@bwbarrett bwbarrett removed this from the v3.0.0 milestone Jul 28, 2017
@bwbarrett
Copy link
Member

bwbarrett commented Jul 28, 2017

@jladd-mlnx, please don't add 3.0.0 milestone to a patch on master. Feel free to add it to the issue (and add the blocker label so we won't release 3.0.0 before the issue is fixed), but this particular PR doesn't impact 3.0.0 directly and adding milestones just makes the release managers' job harder.

rhc54
rhc54 approved these changes Jul 28, 2017
View reviewed changes
Copy link
Contributor

@rhc54 rhc54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me

@rhc54 rhc54 merged commit 0c8a73a into open-mpi:master Jul 28, 2017
@jladd-mlnx
Copy link
Member

jladd-mlnx commented Jul 28, 2017

@bwbarrett Roger that.

@karasevb karasevb deleted the fix_hangs_pmix1 branch March 21, 2018 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhc54 rhc54 rhc54 approved these changes

@artpol84 artpol84 Awaiting requested review from artpol84

Assignees

No one assigned

Labels

bug Severity: critical

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@karasevb @artpol84 @bwbarrett @jladd-mlnx @rhc54