btl/openib: add conditional around an assert #5147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A user trying to build Open MPI with explicit use of CFLAGS on the make command line hit problems. This fixes one of the problems. https://www.mail-archive.com/users@lists.open-mpi.org//msg32241.html Signed-off-by: Howard Pritchard <hppritcha@gmail.com>
Member
Author
|
this is kind of gross but the assert must have been in there for a reason. |
hppritcha
changed the title
Contributor
|
@hppritcha I'm a little puzzled by this one. We have asserts all over the code base - obviously, if you disable debug but set optimizations to 0, they won't be compiled out. So won't you need to protect them everywhere? I'm asking because it sounds instead like there is an actual bug that is being covered up here. |
Member
|
This one does seem to be correct -- that field only exists (via |
Contributor
|
Ah, ok - that's the clarification I was missing. Perhaps a comment would help future-person? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user trying to build Open MPI with explicit use
of CFLAGS on the make command line hit problems.
This fixes one of the problems.
https://www.mail-archive.com/users@lists.open-mpi.org//msg32241.html
Signed-off-by: Howard Pritchard hppritcha@gmail.com