pmix: added check for pmix fence status #5498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karasevb
force-pushed
the
pmix_fence_status
branch
from
eac3cc0 to
8d02007
Compare
hoopoepg
approved these changes
Jul 31, 2018
karasevb
force-pushed
the
pmix_fence_status
branch
3 times, most recently
from
d585cfa to
221dc37
Compare
|
The IBM CI (GNU Compiler) build failed! Please review the log, linked below. Gist: https://gist.github.com/c7391e8f58032139aeb5325d6e23f29c |
|
The IBM CI (XL Compiler) build failed! Please review the log, linked below. Gist: https://gist.github.com/0fe463389af62da504c537cf69f68475 |
|
The IBM CI (PGI Compiler) build failed! Please review the log, linked below. Gist: https://gist.github.com/1d1f14f27d9637dd6c832ac665a10a75 |
karasevb
force-pushed
the
pmix_fence_status
branch
2 times, most recently
from
9f6cc79 to
a9bb90b
Compare
rhc54
requested changes
Jul 31, 2018
| if (OMPI_SUCCESS != (ret = opal_pmix.fence_nb(NULL, 0, fence_cbfunc, | ||
| (void*)&active))) { | ||
| OMPI_ERROR_LOG(ret); | ||
| } |
Contributor
There was a problem hiding this comment.
If the fence operation returns an error, then the wait_for_completion is never going to happen. You need to skip that step.
Member
|
@karasevb we use the release stream tags on the underlying issue and for a PR into a non-master branch. |
Signed-off-by: Boris Karasev <karasev.b@gmail.com>
karasevb
force-pushed
the
pmix_fence_status
branch
from
a9bb90b to
5768336
Compare
rhc54
approved these changes
Aug 6, 2018
This was referenced Aug 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5086