btl openib: only initialize CPCs if there are devices to use #555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquyres
force-pushed
the
pr/openib-delay-cpc-init
branch
from
f4e5ca6 to
3195214
Compare
|
Sent from
|
Refer to this link for build results (access rights to CI server needed): |
Member
Author
|
@hjelmn reviewed this and gave me an "ok" in IM. He says that Jenkins explicitly tests openib, so it should have failed if I broke something. I think @hppritcha is going to specifically test this, though, so I'll wait for his ok before merging it in. |
Defer initializing the CPCs until we know that we have devices/ports to use. This both prevents some useless work at startup when there are no devices/ports to use, and also prevents librdmacm complaining that there are no verbs-capable RDMA devices available (e.g., if a Cisco usNIC device is present, but does not present a verbs RDMA interface).
jsquyres
force-pushed
the
pr/openib-delay-cpc-init
branch
from
3195214 to
202f648
Compare
Member
Author
|
@hjelmn @hppritcha I would like to merge in #565, and it depends on this PR. Can you please review / test? Thanks. |
|
|
Refer to this link for build results (access rights to CI server needed): |
Member
|
This worked for me on one of the mlnx clusters here. |
jsquyres
added a commit
that referenced
this pull request
May 5, 2015
btl openib: only initialize CPCs if there are devices to use
jsquyres
pushed a commit
to jsquyres/ompi
that referenced
this pull request
Nov 10, 2015
Add config code to check for need of workaround. Add runtime way to turn off just in case.
markalle
pushed a commit
to markalle/ompi
that referenced
this pull request
Sep 12, 2020
Selective sync with upstream Open MPI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defer initializing the CPCs until we know that we have devices/ports to use. This both prevents some useless work at startup when there are no devices/ports to use, and also prevents librdmacm from complaining that there are no verbs-capable RDMA devices available (e.g., if a Cisco usNIC device is present, but does not present a verbs RDMA interface).
@hjelmn Can you please confirm that I didn't break anything?