Squash a bunch of harmless compiler warnings. #5779
Merged
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
bwbarrett
reviewed
Sep 26, 2018
| if (orte_get_attribute(&proc->attributes, ORTE_PROC_HWLOC_BOUND, (void**)&bd, OPAL_PTR)) { | ||
| if (NULL == bd) { | ||
| (void)strncpy(tmp1, "UNBOUND", strlen("UNBOUND")); | ||
| (void)strncpy(tmp1, "UNBOUND", sizeof(tmp1)); |
Member
There was a problem hiding this comment.
I know this PR is closed, but you're asking me to review the PRs into release branches. This patch isn't really any better. strncpy() is not guaranteed to NULL terminate the string, so this can still cause memory corruption down stream. Better would be to explicitly set tmp1[sizeof(tmp1) - 1] = '\0'; after the strncpy() to make sure the string is NULL terminated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jeff Squyres jsquyres@cisco.com