v4.0.x: Squash a bunch of harmless compiler warnings. #5785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquyres
force-pushed
the
pr/v4.0.x/more-compiler-warnings-fixes
branch
from
14562d5 to
58cda9c
Compare
Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit 6bb356a)
jsquyres
force-pushed
the
pr/v4.0.x/more-compiler-warnings-fixes
branch
from
58cda9c to
37a9cf5
Compare
Member
|
bot:retest:ppc |
gpaulsen
approved these changes
Sep 28, 2018
Member
|
Jeff, why the WIP-DNM? Waiting for Brian, or some other issues? |
Member
Author
|
Waiting on #5786 |
gpaulsen
previously requested changes
Oct 1, 2018
Member
gpaulsen
left a comment
gpaulsen
left a comment
There was a problem hiding this comment.
This has been reworked on master, and should be re-done.
Member
Author
|
Per discussion on 2018-10-09 webex, leave this PR as-is (i.e., don't add more compiler warnings fixes); it stands alone by itself as a simple compiler warning fix. |
bwbarrett
approved these changes
Oct 16, 2018
jsquyres
dismissed
gpaulsen’s stale review
Dismissing Geoff's negative review because it was 2 weeks ago, and this PR has changed significantly since then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jeff Squyres jsquyres@cisco.com
(cherry picked from commit 6bb356a)