comomn_ompio_file_read/write: fix 2GB limiting issue #7047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgargabriel
force-pushed
the
pr/v4.0.x-hdf5-2gb-bug
branch
from
8d3d01f to
f3ef0f2
Compare
raafatfeki
approved these changes
Oct 5, 2019
Member
|
@gpaulsen ready to merge |
Contributor
|
The commit messages references the wrong issue. I think it should be #7045 instead. |
Member
Author
|
@ggouaillardet you are right, thanks. I can't fix the reference in the commit message anymore, but I fixed it in the pr. |
Member
|
@edgargabriel I'd be okay if you want to update the commit message on the commit and force push. It'd be inconsistent with the master commit, but it might be "more useful". What do you think? |
individual read/write operations exceeding 2GB fail in ompio due to improper conversions from size_t to int in two different locations. This commit fixes an issue reported by Richard Warren from the HDF5 group. Fixes Issue open-mpi#7045 Cherry-picked from commit a130f56 Signed-off-by: Edgar Gabriel <egabriel@central.uh.edu>
edgargabriel
force-pushed
the
pr/v4.0.x-hdf5-2gb-bug
branch
from
f3ef0f2 to
a3e1ecc
Compare
Member
Author
|
@gpaulsen I fixed the issue no on the commit. |
Contributor
|
retest |
Contributor
|
bot:ompi:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
individual read/write operations exceeding 2GB fail in ompio
due to improper conversions from size_t to int in two different
locations. This commit fixes an issue reported by Richard Warren
from the HDF5 group.
Fixes Issue #7045
Signed-off-by: Edgar Gabriel egabriel@central.uh.edu