Topic/fcoll fixes #779
Merged
Topic/fcoll fixes #779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e sm and individual component.
…y. The reason is that otherwise the redirection to the ompi_file_t structure (and back to the ompio internal structure) is ambiguise and wrong for the shared file pointer scenario.
|
@ggouaillardet I actually wanted to thank, it is very valuable that somebody else also looks at the code and runs the IO tests. You are also btw. right that I broke something in mpi_test_suite that used to pass, in one of my optimizations that I introduced a couple of days back. I am working on that right now. |
jsquyres
pushed a commit
to jsquyres/ompi
that referenced
this pull request
Aug 23, 2016
Added Intel HFI1 default parameters for openib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ggouaillardet I included your fix for lockedfile sharedfp component, and provided the other two fixes required. This way, the selection logic for individual remains unchanged. Could you please have a look, it fixes your test case on my machines. Thanks!
@jsquyres thanks for helping with extracting the correct patch from @ggouaillardet branch, and remove the one that we do not need.