Add explicit implementation of Cloneable #786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Cloneable to the implemented interface list as per Coverity suggestion. The required methods were already implemented, but it was not explicitly stated. This is an intent revealing change. Signed-off-by: Nathaniel Graham <ngraham@lanl.gov>
|
looks good. |
hppritcha
added a commit
that referenced
this pull request
Aug 8, 2015
Add explicit implementation of Cloneable
jsquyres
pushed a commit
to jsquyres/ompi
that referenced
this pull request
Aug 23, 2016
…_mdbind BTL portals4: remove useless PtlMDBind PtlMDRelease calls for RMDA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Cloneable to the implemented interface list as per
Coverity suggestion. The required methods were already
implemented, but it was not explicitly stated. This is
an intent revealing change.
Coverity pointed out this lapse.
Signed-off-by: Nathaniel Graham ngraham@lanl.gov
@hppritcha @jsquyres