Skip to content

consolidated per-host affinity display in --mca ompi_display_comm 1 #8842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

consolidated per-host affinity display in --mca ompi_display_comm 1 #8842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61822ff
consolidated per-host affinity display in --mca ompi_display_comm 1
markalle Apr 22, 2021
f02c903
post-review updates: strncpy, hwloc versioning, load topology
markalle Jan 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ompi/mca/hook/comm_method/hook_comm_method.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ extern int mca_hook_comm_method_verbose;
extern int mca_hook_comm_method_output;
extern bool mca_hook_comm_method_enable_mpi_init;
extern bool mca_hook_comm_method_enable_mpi_finalize;
extern bool mca_hook_comm_method_enable_show_aff;
extern int mca_hook_comm_method_aff_columns;
extern int mca_hook_comm_method_max;
extern int mca_hook_comm_method_brief;
extern char *mca_hook_comm_method_fakefile;
Expand Down
20 changes: 20 additions & 0 deletions ompi/mca/hook/comm_method/hook_comm_method_component.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,20 +71,25 @@ enum mca_hook_comm_method_mode_flags_t {
OMPI_HOOK_COMM_METHOD_INIT = 0x01,
/* Display on MPI_FINALIZE */
OMPI_HOOK_COMM_METHOD_FINALIZE = 0x02,
/* show affinity by default, allow noaff to skip it */
OMPI_HOOK_COMM_METHOD_SKIP_AFFINITY = 0x04,
};

int mca_hook_comm_method_verbose = 0;
int mca_hook_comm_method_output = -1;
bool mca_hook_comm_method_enable_mpi_init = false;
bool mca_hook_comm_method_enable_mpi_finalize = false;
bool mca_hook_comm_method_enable_show_aff = true;
uint32_t mca_hook_comm_method_enabled_flags = 0x00;
int mca_hook_comm_method_max = 12;
int mca_hook_comm_method_aff_columns = 80;
int mca_hook_comm_method_brief = 0;
char *mca_hook_comm_method_fakefile = NULL;

static mca_base_var_enum_value_flag_t mca_hook_comm_method_modes[] = {
{.flag = OMPI_HOOK_COMM_METHOD_INIT, .string = "mpi_init"},
{.flag = OMPI_HOOK_COMM_METHOD_FINALIZE, .string = "mpi_finalize"},
{.flag = OMPI_HOOK_COMM_METHOD_SKIP_AFFINITY, .string = "noaff"},
{0, NULL, 0}
};

Expand Down Expand Up @@ -137,6 +142,7 @@ static int ompi_hook_comm_method_component_register(void)
*/
mca_hook_comm_method_enable_mpi_init = false;
mca_hook_comm_method_enable_mpi_finalize = false;
mca_hook_comm_method_enable_show_aff = true;
mca_base_var_enum_create_flag("ompi_comm_method", mca_hook_comm_method_modes, &mca_hook_comm_method_flags);

ret = mca_base_component_var_register(&mca_hook_comm_method_component.hookm_version, "display",
Expand All @@ -161,6 +167,9 @@ static int ompi_hook_comm_method_component_register(void)
if( mca_hook_comm_method_enabled_flags & OMPI_HOOK_COMM_METHOD_FINALIZE ) {
mca_hook_comm_method_enable_mpi_finalize = true;
}
if( mca_hook_comm_method_enabled_flags & OMPI_HOOK_COMM_METHOD_SKIP_AFFINITY ) {
mca_hook_comm_method_enable_show_aff = false;
}
}

// hook_comm_method_max
Expand All @@ -171,6 +180,17 @@ static int ompi_hook_comm_method_component_register(void)
OPAL_INFO_LVL_3,
MCA_BASE_VAR_SCOPE_READONLY,
&mca_hook_comm_method_max);
// hook_comm_method_aff_columns
ret = mca_base_component_var_register(&mca_hook_comm_method_component.hookm_version, "aff_columns",
"Number of hosts for which to print unabbreviated 2d table of comm methods.",
MCA_BASE_VAR_TYPE_INT, NULL,
0, 0,
OPAL_INFO_LVL_3,
MCA_BASE_VAR_SCOPE_READONLY,
&mca_hook_comm_method_aff_columns);

(void) mca_base_var_register_synonym(ret, "ompi", "ompi", NULL, "display_comm_aff_columns", MCA_BASE_VAR_SYN_FLAG_INTERNAL);

// hook_comm_method_brief
(void) mca_base_component_var_register(&mca_hook_comm_method_component.hookm_version, "brief",
"Only print the comm method summary, skip the 2d table.",
Expand Down
Loading