Add OPAAutoConfiguration to define common beans
#28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orizationManager` beans
anderseknert
approved these changes
Feb 17, 2025
| [externally](https://docs.spring.io/spring-boot/reference/features/external-config.html), e.g. via | ||
| `application.properties`, `application.yaml`, system properties, or environment variables. | ||
|
|
||
| Example `application.yaml` to modify properties: |
| private Map<String, OPAAuthorizationManager> opaAuthorizationManagers; | ||
|
|
||
| @Test | ||
| public void test() { |
There was a problem hiding this comment.
Is it convention to name the tests test, or could we use something more descriptive?
There was a problem hiding this comment.
At first I used simple test name since there was 1 test method per class, but as you suggested better to use more descriptive names. Just updated. :)
…orizationManager` beans - rename test methods
|
Thanks! 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
OPAAutoConfigurationto auto-configureOPAClientandOPAAuthorizationManagerbeans.Implements #22