Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in rmf_traffic_schedule_node #27

Closed
destkk opened this issue Apr 8, 2021 · 1 comment
Closed

Error in rmf_traffic_schedule_node #27

destkk opened this issue Apr 8, 2021 · 1 comment

Comments

@destkk
Copy link

destkk commented Apr 8, 2021

Hi there. I have tried launching a demo launch file and apparently there is a dispatcher node error which results to failure in launching. I have not edited any of the files from provided by RMF demos and core. May I know what could be the cause of these errors?

[INFO] [launch]: All log files can be found below /home/rosuser/.ros/log/2021-04-08-11-23-22-099046-rosuser-4672
[INFO] [launch]: Default logging verbosity is set to INFO
[INFO] [rmf_traffic_schedule-1]: process started with pid [4674]
[INFO] [rmf_traffic_blockade-2]: process started with pid [4676]
[INFO] [door_supervisor-3]: process started with pid [4678]
[INFO] [lift_supervisor-4]: process started with pid [4680]
[INFO] [rmf_task_dispatcher-5]: process started with pid [4682]
[rmf_task_dispatcher-5] ~Initializing Dispatcher Node~
[rmf_task_dispatcher-5] [INFO] [1617852202.374765163] [rmf_dispatcher_node]:  Declared Time Window Param as: 2.000000 secs
[rmf_task_dispatcher-5] [INFO] [1617852202.374846947] [rmf_dispatcher_node]:  Declared Terminated Tasks Max Size Param as: 100
[rmf_task_dispatcher-5] [INFO] [1617852202.381721003] [rmf_dispatcher_node]: Starting task dispatcher node
[rmf_traffic_blockade-2] [INFO] [1617852202.383422101] [rmf_traffic_blockade_node]: Beginning traffic blockade node
[rmf_traffic_schedule-1] [FATAL] [1617852202.495543207] [rmf_traffic_schedule_node]: Failed to correctly load participant registry: yaml-cpp: error at line 915, column 11: bad conversion
[rmf_traffic_schedule-1] 
[rmf_traffic_schedule-1] terminate called after throwing an instance of 'std::runtime_error'
[rmf_traffic_schedule-1]   what():  yaml-cpp: error at line 915, column 11: bad conversion
[ERROR] [rmf_traffic_schedule-1]: process has died [pid 4674, exit code -6, cmd '/home/rosuser/rmf_ws/install/rmf_traffic_ros2/lib/rmf_traffic_ros2/rmf_traffic_schedule --ros-args --params-file /tmp/launch_params_lzwgc264'].

@mxgrey
Copy link
Collaborator

mxgrey commented Apr 8, 2021

We've seen this issue popping up a few times for various users, but haven't been able to reproduce the issue reliably. This may be an opportunity for us to get some insight on what might be causing it.

Could you do me a favor and look at the contents of a hidden file called .rmf_schedule_node.yaml that will live in whatever directory you call ros2 launch ... from? (Presumably the file will be ~/rmf_ws/.rmf_schedule_node.yaml).

Then copy/paste the entire contents of that file into a gist, create a public gist and link us to it. Or if there's any reason you don't want to share the contents publicly, you could also send me an email with the file's contents, and I'll keep it confidential.

Being able to see the contents of that file might help us identify why this has been happening randomly for some users.

After you've shared the contents with us, you can simply delete that file and then everything should work fine again. You should also consider updating your rmf_internal_msgs, rmf_traffic, and rmf_ros2 repos by running git pull origin main in each of those folders inside of ~/rmf_ws/src/rmf/, because it's possible (but not confirmed) that this issue is related to this bug fix.

mxgrey added a commit that referenced this issue May 6, 2021
* Added models

* Updated office.rviz

* made changes according to issues

* changing launch xml files to use the var

* cleaning up readme and deprecated demos

* added basic airport terminal demo

* added screenshot

* fixed office launch missing arg, added more loops in launch, cleaned up waypoints, added new fleet lanes

* organized launch files, fixed nav graph number, lane mistakes

* fixed duplicate waypoint name

* fixed launch file name

* spawning magnis outside of charging room to save some time on getting out

* adding loop launch instruction to readme

* Fixed argument in office launch and map_name in rviz panel

* Added caddy model with readonly plugin

* Feature/airport terminal (#24)

* added basic airport terminal demo

* added screenshot

* fixed office launch missing arg, added more loops in launch, cleaned up waypoints, added new fleet lanes

* organized launch files, fixed nav graph number, lane mistakes

* fixed duplicate waypoint name

* fixed launch file name

* spawning magnis outside of charging room to save some time on getting out

* adding loop launch instruction to readme

* Fixed argument in office launch and map_name in rviz panel

Co-authored-by: Yadunund <yadunund@openrobotics.org>

* Initialize start waypoint

* spawn robots instead of adding to sdf, WIP issues with motion after spawning

* added spawn and loop launch scripts, WIP resolving issue of hesitant robots

* renamed the launch files to corrent ones, WIP hesitant robots

* Teleop joystick added to launch

* Modified caddy drive parameters and introduced rmf_traffic dependency

* starting work on delayed loop requester

* Plugin now predicts look_ahead waypoints

* scenario launch file and delayed request

* Cleanup

* change to using shell script to prevent race condition, TODO check delays on laptops

* updated readme

* minor cleanup

* adding second script to only spawn without sending any tasks

* added note about possible race conditions and launch failures

* removed note about race conditions and pkill commands

* removed unused launch files, removed race-condition task request launch file

* Fixes

* oops, missed a conflict resolution

* Fixes

* Feature/caddy track (#27)

* reduced shop size, reduced number of floor models

* made the stall islands smaller, WIP adding caddy lanes

* tidied up the floor tiles, chose texture, added caddy track

* cleaned up world, removed doors, WIP figure out why doors are not rendering

* allow plugin to handle single doors, testing .building.yaml

* testing minor door stuff

* removed door testing stuff, ready to cleanup and merge

* cleanup, removed door testing stuff

* changing the screenshots

* renewed docs

* change build test to use rosdep

* corrected build test

* rosdep update

* skipping some keys

* skipping libgazebo9 in rosdep

* adding sudo to rosdep command, removing skip keys

* added skip keys

* continue installing despite errors

* removed gazebo installation step, updted readme as debug notes

* adding ignore keys to readme

* Updated configs

* Feature/office single doors (#31)

* using building_gazebo_plugins instead, cleaned up, WIP testing hinged doors

* removed doors in airport first

* Set coke model to non-static

* added some basic instructions to solve missing models race-condition … (#39)

* added some basic instructions to solve missing models race-condition when launching demos

* typo 💀

* added link

* modifying Caddy model paths instead

* Feature/doors (#42)

* added double hinged doors at strategic locations

* testing double hinged door on office, adding new robot behind doors scenario

* corrected office building test

* added lanes, changed 3rd mir loop route to pass through doors, manually added wall segments for doors

* Ensure lanes overlap

* Added two new loop scenarios

* Install loop scenario files

* Modified position of junction_n02

Co-authored-by: Yadunund <yadunund@openrobotics.org>

* added extra demo assets, TODO replace with model download pipeline (#46)

* Feature/split scenarios (#48)

* split launches into caddy and no-caddy, fixed missing mir100_2

* fix overlapping lanes, door remains open issue

* fixed another overlap, door waypoints slightly further

* Minor enhancement to readonly plugin (#52)

* POC merge lane

* POC merge lane

* Added lane_threshold to control merging of robot into its lane

* Spawning caddy without launching airport_terminal world

* Format fix

* Feature/model handling (#53)

* added scripts and basic config file to download fuel models

* removed fuel models, added instructions to download to disk

* steps to download fuel models to tmp folders raw

* updated readme

* removed office chairs

* airport_terminal with all the just added assets

* cleaned up airport_terminal, added fuel_model path to office, included back non-broken officechairs

* added all the supposed fue fuel models into local repo, will handle downloading from fuel in next features

* removed model thumbnails and removed ignition fuel installation line on readme

* missed models from dropbox, accidentally lefleft in debugging .building.yaml (#54)

* added launch xml to exec depend

* Update airport_terminal.building.yaml

* Added missing bookshelf asset.

* Removed Bookshelf asset

* Fix/airport map (#59)

* Downsampled assets in simulation

* More downsampling

* Adjusted lanes

* Adjusted lanes

* Minor fixes

* fixed duplicate wood texture

* Updated scenarios

* Updated scenarios

* Added new magni lane

* Changed location of magni_0 placeholder

* Added new magni lane

* Removed magni_1 placeholder

* Modified caddy placeholder

* Modified magni_2 placeholder

* Added more doors

* Deleted one door

* Removed oak tree in the middle

* Undo change to RobotPlaceholder

* Modified caddy velocity parameters

* Matched magni fleet adapter parameters with those in slotcar

* Modified motion params of Mir100

* Removed oak tree

* Disabled caddy merge lane

* Feature/teleport plugin v2 (#62)

* experimenting with placeholder links on models, refactoring teleport to have dispenser stuff

* no need for mutexes

* fixed RobotPlaceholder model, teleport plugin works, now v3 to remove target name

* extended respawn to 5 seconds, caching modelptrs instead of names

* handle duplicate dispenser request guids

* cleaned up dispenser script and usage

* removed launch call for dispensers

* added new respawn seconds sdf element, added delivery scenario

* Added loop launch file

* fix gazebo_ros_pkgs meta package as dependency (#65)

* Updated scenarios

* Cleaned up scenarios

* Updated README.md

* updated gazebo_models link to migrated github link (#72)

* Feature/non intrusive dispenser (#69)

* finished first iteration of TeleportDispenser, crashing at world start

* ingestor working, need to figure out how to teleport it back to dispenser

* TeleportIngestor working with office and airport demos, removed old teleport plugin

* removed old teleport plugin, removed odd vscode artifact

* minor cleanup, const correctness

* removed delay before dispensing, made respawn by ingestor 10 seconds

* made function names more verbose and const qualify variables

* Updated API call usage in RMFPanel

* Added FAQ

* Updated README.md

* Updated adapter launches

* Updated robot vicinity radii

* Updated mir vicinity

* Moved read_only_fleet_adapter launch into airport_terminal.launch.xml

* Started using new commands from building_map_tools (#76)

* Using new building_map_generator (#77)

* Using new building_map_generator

* Added instructions for new python dependency from pit_crew, added to workflow

* Added instructions for pit_crew deps python3-requests to README and build test (#78)

* Office scenario assets uploaded to fuel

* Update README.md

* Updated request_delivery with pickup and dropoff dispener names

* Fixed dangling waypoint

* add headless launch option

* Added newly migrated Door panels

* Reverted some automatic changes when updating configs

* Adding marker subscriber for /building_systems_markers

* Uploaded all internal rmf_demo_assets to fuel

* Demo .building.yaml updated with Fuel model names

* Updated .building.yaml with newest thumbnails

* Develop (#85)

* Updated request_delivery with pickup and dropoff dispener names

* Fixed dangling waypoint

* Added newly migrated Door panels

* Reverted some automatic changes when updating configs

* Adding marker subscriber for /building_systems_markers

* Fixes for first release (#84)

* Removed workcell names from maps and added delivery launch files

* Updated RMF panel with new Delivery message structure. Updated rviz configs

* Linted with pycodestyle

* Updated build.yaml

* RMF linter

* Fixed EOL error

* Updated README.md

Co-authored-by: Yadunund <yadunund@openrobotics.org>

* Install scripts properly in symlink installs

Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>

* adding auto-generated changelogs

* 1.0.0

* Added flag for not downloading models when doing build tests or without internet connection

* Reduced scope of build testing only for dependencies of local packages

* Updated changelogs

* Fixed typos

* Fixed model orientation

* fixing ament_cmake dependency

* Fix build problems (#96)

* World name strip fails when . in path fixed

* adding ros2run as build dependency

* Invoking model downloading with a separate custom command

* Using custom commands within if condition due to required OUTPUT or TARGET cmake variable

* Update rmf_demo_maps/CMakeLists.txt

Co-authored-by: Marco A. Gutiérrez <marco@openrobotics.org>

* Update rmf_demo_maps/CMakeLists.txt

Co-authored-by: Marco A. Gutiérrez <marco@openrobotics.org>

* Move message call outside of custom command call

* Adding rviz2 as execution dependency

* Removed deprecated models instructions, only using downloads from Fuel

* Added reference to package rmf_demo_maps building

* Removed compiling instructions

* Changed name of resource folder to rmf_dashboard_resources

* Removed name of world of the Json file

* Rename Magni to TinyRobot, MiR100 to DeliveryRobot

change names

* code style after renaming

* Removed dispensers.json file

* Renamed instances of MiR100 to DeliveryRobot and Magni to TinyRobot

* Updated main.json with DeliveryRobot and TinyRobot

* name changes in CHANGELOG.rst and model.config

* Modify TeleportIngestor to use rmf_ingestor_msgs

Changed TeleportIngestor to use rmf_ingestor_msgs. Enables future
differentiation between both Ingestors and Dispensers.

* Foxy (#103)

* Use C++17 standard to match SDFormat9 requirement

Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>

* Update rmf_gazebo_plugins/CMakeLists.txt

Co-authored-by: Yadu <yadunund@openrobotics.org>

* Use AxisAlignedBox instead of Box for bounding boxes

Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>

* Remove redundant moves to enable RVO

Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>

* Updated resource path from gazebo-9 to gazebo-11

* Updated panel layout

* Fixed format

* branch for ignition-math4 vs ignition-math6

Signed-off-by: Yadunund Vijay <yadunund@openrobotics.org>

* Set default gazebo version to gazebo-11

* Fixed formatting

* Update README.md

Signed-off-by: Yadunund Vijay <yadunund@openrobotics.org>

* Update README.md

Signed-off-by: Yadunund Vijay <yadunund@openrobotics.org>

* Update demos/launch/airport_terminal.launch.xml

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>

* Update README.md

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>

* Update demos/launch/airport_terminal.launch.xml

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>

* Update demos/launch/office.launch.xml

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>

* Update demos/launch/office.launch.xml

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>

* Fixed formatting

Signed-off-by: Yadunund Vijay <yadunund@openrobotics.org>

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>

* Added coke ingestor and coke dispenser configurations to dashboard resources (#122)

* Modify moment of inertia tensors for Caddy wheels (#129)

Adjust the inertia values for the 4 wheels in order to satisfy the
triangle inequalities for the inertia matrix. Inertia values are
estimated assuming a thick walled solid cylindrical shell shape.

* remove build output

* install dashboard resources as ament package

* only generate main.json when inputs changes

* commit main.json to support installing from git

* Imaginary clinic world and hotel world (#120)

* add request_lift test script

* add lift_test

* add navigation graph in test

* Improve appearances

* remove mannually created holes for lifts

* modify map to meet new editor & demo

* fix hotel demo

* fix hotel scenario

* Add imaginary clinic

* python codestyle

* Add HOSPI model, fix model names, fix door orientation

* extension on hotel

* hotel map

* Fix model orientations

* conference map

* Edit waypoint properties

* Changed model name to HospitalRobot, added dependency to building_gazebo_plugins

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* change names to HospitalRobot in launch and map

* two level map

* Edit robot inertial

* hotel

* update imaginary clinic map

* add lift control in hotel launch

* rename robots

* update map and readme

* add delivery and loop launch, add more robots

* migrate lift_test to test/lift_test_world

* working hotel demo

* add lift supervisor to lift test

* clean assets

* remove unnecesary launch file

* unknown paramter removed

* fix robot naming

* Update README.md

* Add hotel traffic editor view

* Update README.md

* Update README.md

* change model names to match thumbnails

* Update README.md

* fix models and rviz layout

* Clean up unused dependency

* Replace unavailable models

* update lift configurations

* Rename imaginary_clinic to clinic

* update readmes and bot vel profile

* Add hotel doors & full hotel (#128)

* hotel with doors

* door working now

* Delete .gitignore

* add full hotel plan

* remove unnecessary robot

Co-authored-by: Yadu <yadunund@openrobotics.org>

* Configurable gazebo version with default Gazebo11

* Update rviz configs

* Deleted hotel_full launch file

Co-authored-by: MakinoharaShouko <qianj4@uw.edu>
Co-authored-by: Aaron Chong <aaronchongth@gmail.com>
Co-authored-by: MakinoharaShouko <57300801+MakinoharaShouko@users.noreply.github.com>
Co-authored-by: youliang <tan_you_liang@hotmail.com>
Co-authored-by: Yadu <yadunund@openrobotics.org>

* Debugging the traffic light API

* Adding a new Triple-H map and traffic light mock fleet adapter

* Debugging

* Add github workflow for Foxy builds (#132)

* Add github workflow for Foxy builds

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* Remove eloquent change

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* Fix gazebo repo

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* Removed boost manually installed packages

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* Removed eloquent build

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* Fix workflow name

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* Update documents dropping Eloquent support

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* Update main README

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* add floorplan to rviz (#133)

* Clinic dashboard fixes (#136)

* add drawing to L1 of clinic

* clinic positioning so L1 shows up on dashboard

* adjust lifts

* offset reset to 0, increase elevation

* downsize lifts to stop physics jiggling

* Updated view in RViz and walls around lift shaft doors

Co-authored-by: Yadunund Vijay <yadunund@openrobotics.org>

* Updated changelogs for release 1.1 (#138)

Signed-off-by: Yadunund Vijay <yadunund@openrobotics.org>

* Finish 'The Pedigree' demo

* Update CHANGELOG

* updates on changelogs and package version (#140)

* Change texture.png to more explicative name (#142)

* Change texture.png to more explicative name

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* Add changelog

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* Basic floor plan and walls setup

* Using newly rotated CGMClassic thumbnails

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Using newly rotated CGMClassic model and thumbnail

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* MonitorAndKeyboard model might require new thumbnails as well, the placements seem wrong

* Environment setup complete, graphs are next

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Duplicated second level

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* setting all packages to version to 1.1.0 (#148)

* Added lifts 24, 25, 1, 2, for clinic_2

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Basic L1 graph, TODO parking and holding points

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Adding keys and values for plugin removal option

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Dispensers/add icon (#156)

* add human icon to demos

* correct ingestor spelling

* rotate human icon

* Added similar stopping distances to DeliveryRobot and HospitalRobot, clinic_2 now works with a 2 level nav graph

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Replaced original clinic simulation, completed 2 floors with 2 sets of robots

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix faulty clinic map names in launch files

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Replacing documentation and gifs, adding loop launch xml

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Adding new line to readme

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Secured ros2 office demo (#135)

* adding sros2 office demo files

* discovery topic not needed in policies

* adding instructions for the office sros2 demo

* fix office gif location

* set parameters to match node names

* Update README.md

Co-authored-by: Yadu <yadunund@openrobotics.org>

* Update README.md

Co-authored-by: Yadu <yadunund@openrobotics.org>

* Update README.md

Co-authored-by: Yadu <yadunund@openrobotics.org>

* Update README.md

* updating policies to new topics

* targeting 1.1.0 and gzclient issue

* updating changelog

* tmux script and updated instructions

* typos

* fix gazebo_model_path at tmux script

Co-authored-by: Yadu <yadunund@openrobotics.org>

* adding rviz2 subscriptions to policies

Co-authored-by: Yadu <yadunund@openrobotics.org>

* Add Ignition simulation plugins and demos (#152)

* add request_lift test script

* add lift_test

* add navigation graph in test

* Add ignition world generation to CMakeLists

* Added basic launch files for ignition

* Adapted to latest changes in package naming, added fleet adapter to ign demo

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* Added ros_ign_bridge for clock

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* Fix build errors

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* Fix office_ign demo by removing dispensers

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* Added instruction on setting up and running ignition demos

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* Remove mercurial from ign dependencies

* Add warning about ros2 version

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* Added changes from master to ign launch

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* Improve appearances

* Collision bitmask PR merged, back to master

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* remove mannually created holes for lifts

* Revert to previous package naming for plugins

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* add lift_test_ign launch file

* Add .gazebo folder to models path

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* fix model path and orientation

* fix nav_graph path

* Ignition dome version bump

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* Create Ignition plugins for TeleportIngestor and TeleportDispenser and refactor with existing Gazebo plugins (#124)

* Create initial TeleportIngestor and TeleportDispenser Ignition plugins

New ignition plugins mimic behavior of the existing Gazebo plugins with
the same name. Also created empty new rmf_plugins_common package which
will house code common to both the Ignition and Gazebo plugins.

* Create modularized TeleportDispenser Ignition and Gazebo plugins

Modify Gazebo plugin to mimic asynchronous control flow of the Ignition
plugin. Refactor both plugins to separate the ROS node and message
passing from the simulation aspects, moving the former to the new
TeleportDispenserCommon class.

Currently, the TeleportDispenser state and any publishers/subscribers
are in the TeleportDispenserCommonClass, while any functions to locate
and move objects are located in the respective Ignition/Gazebo plugin
classes.

* Create modularized TeleportIngestor Ignition and Gazebo plugins

Modify Gazebo plugin to mimic asynchronous control flow of the Ignition
plugin. Refactor both plugins to separate the ROS node and message
passing from the simulation aspects, moving the former to the new
TeleportIngestorCommon class.

* Miscellaneous minor enhancements and cleanup

- Check if ingestor is filled before attempting to ingest item.
- Check if bounding box of ingestor contains item in addition to merely
  checking distance.
- Send failure status for ingesting if request does not succeed.
- Move _non_static_init_model_poses to TeleportIngestorCommon
- Standardize indentation to 2 spaces and remove redundant includes
- Move function definitions out of class
- Remove logger() function
- Simplify plugin names amd change Teleport{Ingestor|Dispenser}Common member object names
- Add comments

* Use AxisAlignedBox component(s) when dispensing items

Creates an AxisAlignedBox (AABB) component for item to be dispensed. When
dispensing item, uses the AABB of the robot model to calculate its
subsequent position. Also adds minor indentation changes for various
functions.

* Update Changelog for rmf_ignition_plugins

Update Changelog description for new package containing Ignition Gazebo
plugins for the rmf demos.

* Incorporate rmf_ingestor_msgs and enable demos to run with Gazebo >9

Modifies Ignition and Gazebo TeleportIngestor plugins to send receive
messages defined in rmf_ingestor_msgs. Adds flags to check for Gazebo
version and create bounding boxes of the appropriate type. Lastly,
modifies CMakeLists and package.xml files where appropriate to run with
the latest Gazebo versions.

* Change indentation and formatting to adhere to style guidelines

Adjust indentation, line widths and spacing. Remove underscores for public var names in classes.
Add Ignition plugin paths to Airport and Lift demos.

* Refactor utils lib and Ingestor/Dispenser code structure improvements

- Move utils library to rmf_plugins_common package
- Removes `_load_complete` flag where not necessary.
- Upgrades sdformat version form 9 to 10
- Incorporates static() checking when generating robot lists instead of in
    `find_nearest_non_static_model()`
- ingest_from_nearest_robot and dispense_onto_nearest_robot now return boolean
    values instead of void

* Use generic callback fns for Ingesting/Dispensing

Moves the bulk of the code in the TeleportIngestor and
TeleportDispensers' on_update() or pre_update() functions into common
functions. Passes callback functions to the common function instead to
inject ignition/gazebo-specific code.

* Ignition Math version bump

Use ign-math6 instead of ign-math4. Minor style changes to
request_lift.py

* Fix ign-math dependency in rmf_plugins_common

* Shift simulation_now and response construction into utils

Refactor TeleportIngestorCommon and TeleportDispenserCommon to move
common functions into utils library where possible.

* Move dispenser refill check and current_state updates to common TeleportDispenserCommon

Moves the periodic check for refilling the dispenser into the
TeleportDispenserCommon class. Also moves the current_state updates
to the common classes to ensure no publishers or subscribers are
needed in the individual Ignition or Gazebo plugin classes.

* Move ingesting and disepnsing control logic to common classes

Creates a new SimEntity class to hold identifiers for either Ignition or
Gazebo simulations. This enables dispense_on_nearest() and
ingest_from_nearest_robot() to be moved to the common classes, with
callbacks injected for simulation specific tasks such as moving objects
or identifying the nearest objects.

* Modify SimEntity struct field to be dependent on simulator type

Accessing the entity or name field of a SimEntity object is now
dependent on the Simulator type it is to be used for, which is
implicitly specified when first initializing a SimEntity object.

* Fix Dispenser bounding box generation

- Store the bounding box created in _dispenser_vicinity_box and use that
value instead of assigning it to the Dispenser's BoundingBox/AxisAlignedBox
property.
- Mention use of new rmf_ingestor_msgs in changelog

* Convert utils functions to generic versions

Remove any dependency on Gazebo or sdformat in the sim_utils library by
converting existing functions to templated versions. Clean up
dependencies in the corresponding CMakeLists file.

* Convert Pose data to Eigen Isometry values to work with multiple Gazebo versions

Create template functions to convert between the Pose data type and
Eigen Isometry3d values, and incorporate these into the TeleportIngestor
plugins. Removes the dependency on Ignition Math 6 and enables it to work
with both Gazebo 11 and 9.

* Fix Eigen3 Dependencies in CMakeLists file

Add Eigen3 as target dependency for TeleporIngestorCommon and move
template functions from utils to TeleportIngestorCommon.

* Create Ignition Readonly plugin (#134)

* Create functional Readonly Ignition plugin and replace map placeholders

New Readonly Ignition plugin mimics the existing Gazebo readonly
plugin in terms of behavior. robot_placeholder(s) in the Airport
Terminal map have been replaced with the actual robots themselves.

* Refactor Readonly Gazebo plugin to use ReadonlyCommon class

Moves all non simulator specific code to the ReadOnlyCommon class for
reuse by other simulator plugins. Refactor the existing Gazebo Readonly
plugin to make use of this common class.

* Refactor Readonly Ignition plugin to make use of ReadonlyCommon class

Move non Ignition Gazebo specific code to the common class. Amend
CmakeLists file to remove redundant includes.

* Fix airport demo launch files

Edit description for ignition airport demo launch files, and set default
caddy model plugin name in sdf file to point to the Gazebo plugin.

* Enable both differential drive plugins to work without needing to recompile

- Add both diff drive plugins to sdf file. Serves as a workaround to run both
Ignition and Gazebo classic simulations without needing to edit the
Caddy sdf file to modify plugin names.

- Convert CMake target_link_libraries to ament_target_directories. Remove
comment markers around caddy in launch file.

* Remove ignition math dependency and substitute Eigen library

Removes use of ignition math in ReadonlyCommon, by replacing it with
equivalent Eigen types and functions. Added minor comments in the Caddy
sdf file describing addition of both plugins, as well as some in the
readonly plugin.

* Miscellaneous minor Readonly plugin improvements

- Pass pose and sim time as arguments to `on_update` function to ensure
they get computed each time
- Removed unused `update_count` variable
- Added getter/setter for name variable in `ReadonlyCommon` and changed
its access specifier from public to private
- Modified mutex name to be more descriptive

* Remove _pose and _sim_time local variables from Readonly plugin classes

Initialize the aforementioned variables in the `on_update()` function
instead.

* Add PBR textures to Caddy

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* Fix eigen dependency name

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* Launch file updates to enable Ignition GUI plugins and fix lift_test demo (#144)

* Add paths to Ignition GUI plugins

Modify ignition demo launch files to add path to Ignition GUI plugins.

* Updated docs for release of ignition dome

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* Adjust TinyRobot mass to run smoothly using DART on Ignition (#146)

Currently, the wheels of the TinyRobot slip when attempting to turn
on Ignition with the DART physics engine. This fix modifies the mass
slightly for now, to allow it to run smoothly.

* Support slotcar movement and delivery with Linear/AngularVelocityCmds on Ignition (#150)

* Send Ignition transport messages from TeleportIngestor and Dispenser

Required for slotcar plugin to know when a payload has been dispensed to/
ingested from it.

* Add Clinic Ignition demo launch file

* Reset velocity cmds when ingesting object

Makes TeleportIngestor responsible for all movement of object once it
has been ingested. Remove debugging statements and modifies some
comments.

* Change TeleportIngestor ignition msg type from Uint64 to Entity

Improves maintainability if the current Entity type were ever to change
in Ignition. Also makes a few code style improvements.

* Remove test worlds

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* Remove additional test files

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* Add Ignition installation to github workflow

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* Fix CI script

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* Cleanup environment variables, add hotel demo

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* Merged ignition and gazebo classic launch files

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* Remove demo scripts

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* Remove installation of deleted scripts

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* Commented out caddy in ignition, fixes gazebo crashes

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

Co-authored-by: Kevinskwk <kevinskwk@gmail.com>
Co-authored-by: Rushyendra Maganty <mrushyendra@yahoo.com.sg>

* Adding battle_royale test map

* Adding battle royale launch file

* Update launch files for traffic light tests

* Fix Gazebo crash with both Ignition and Gazebo diff drive plugins in same file (#167)

Adding a slash ensures that dlopen interprets it as a pathname, avoiding
crashes since dlopen will no longer find the ignition plugin.

* Refactor simulation launching into its own launch file

* Fix map name for Triple H

* Update changelog

* changelogs update and version bump (#177)

Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>

* Develop/dispatcher demo2 (#181)

* added battery related parameters

* Updated navgraph for office world

* Updated airport_terminal graph, shifted caddy spawn waypoint.

* Added holding points to clinic world

* Updated battery params with more accurate values

* Cleaned up launch files, rviz configs and added tasks.json files for scheduled tasks

* Added rmf_task_dispatcher to common.launch.xml

* Updated mock traffic light addapter launch file

* Develop/rmf demo panel: a react gui with flask server in place of current rmf panel (#176)

* create new rmf_demo_panel

* update panel server and bot battery capacity

* add react app to frontend

* add tabs for different worlds

* add config file in ts format and loop req form

* add delivery form

* add form validation

* remove dist index

* add dashboard config files and config services

* update instructions and setup.py

* add config changes

* add start time field to forms

* add loop and delivery post methods

* add props to forms for rerender on world change

* add evaluator field and update evaluator names

* add antd lib and progress ui

* shift evaluator field and make optional

* add antd css cdn

* add chip to task cards

* remove card overflow and increased height

* add error messages for input fields

* remove unused package and css loader config

* refactor and remove console messages

* add dist folder to setup and update msg srv

* minor ui changes

* update according to new taskdesciption.msg

* add react testing library and roles to components

* add basic tests for components

* add rostime clock component

* remove clean from office config and format quotes

* remove extra lines

* add test for rostime clock

* change typography variant

* edit readme

* add battery and dock icon to robot card

* add roles to forms

* uniform alignment in task card

* add typography to state labels

* add roboto font cdn

* fix start time

* fix dispenser and ingestor results

* add message box alert for status of request submissions

* add message alert box for scheduled tasks and remove unused console logs

* minor cleanups and edit dashboard configs

* fix pystyle

* fix style

* refactor submission of requests and add new tests for cleaning form

* refactor delivery form and add in tests

* uniform test names and adding tests for loop request form

* refactor start time and evaluator

* add test for scheduled task form and remove evaluators from delivery form

* refactor fetch call into services

* remove mock data and add tests for cards

* add cov to gitignore

* remove redundant test

* remove console.log

* change import lines to import used components only and reconfigure webpack

* add loading div

* remove example cards

* edit readme and remove comments/misspellings

* replace periodic fetch call with socket broadcast

* update readme and package xml to v1.0.0

* remove config loading from server, move delivery conversion to frontend

* change cleaning form header

* update socketio version

* remove unused code

* add cancel task functionality

* remove max height for task card and add cancel task button

* remove tasklist folder

* extract gui server block into common.launch.xml

* split web servers, cleanup launch, docs and repo

* update doc

* cleanup api server script

* move dashboard config files to rmf_dashboard_resources

* revert main.json and add cache for get_tasks in server

* revert main.json config, fix style

* refactor submission of delivery request through scheduled form

* stringify js object for post

Co-authored-by: youliang <tan_you_liang@hotmail.com>

* Updated README

* Fixed typos in README

* Added section on task dispatching to README

* add delayed task fix

* add hotel to rmf panel, minor updates on docs

* update ChangeLog

Co-authored-by: val <valeriebuilds@gmail.com>
Co-authored-by: youliang <tan_you_liang@hotmail.com>
Co-authored-by: vallq <vallq@outlook.com>

* update docs and cleanups

* fix invalid None return during fail submission

* Updated package.xml (#191)

* Fix argument in simulation.launxh.xml (#192)

* add dockerfile

* add trajectory server to common launch set

* Re-introduce request_loop task in rmf_demo_tasks (#195)

* Added request_loop.py

* Fix style

* add link to roadmap and fix rmf_core faq link

Signed-off-by: Morgan Quigley <morgan@osrfoundation.org>

* Add Dispatch Task Script (#199)

* fix server api bug for cancel task

* add script to submit task, update api server and docs

* more checks on script

* fix style

* split dispatch task script

* fix style again

* fix gui success eror msg pop up

* update docs and small fix on progress

* fix issue with sim time for start time

* check res success

* update with --use_sim_time

* fix/Dashboard config for rmf_demo_panel (#201)

* add endpoint for gui to get dashboard_config on runtime

* fix style

* Fix/UI changes (#204)

* clean json fetch errors

* remove delayed chip and add delayed label

* udpate tab tests

* Experimental lift watchdog demo (#205)

* Fix/nodev10 compatiblity (#206)

* switch to old syntax

* switch to old syntax

* Update tasks-container.tsx

* adding npm and flask dependencies, updating install (#203)

* adding npm and flask dependencies, updating install

Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>

* removing npm from installation instructions

Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>

* Update rmf_demo_panel/README.md

* Modifications to office world navgraph (#207)

* Connected bottom graph. Removed cubicle_1 cubicle_2. station_1 replaced with tinyRobot1_charger and tinyRobot2_charger added below lounge

* Map tweaks

* Added conflict file

* Removed cabinet model

* fix: uploading the same json will render the correct text (#208)

* Make launch files more generic (#209)

* Move demos to rmf_demos

Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>

* Rename demos package to rmf_demos

Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>

* Move rmf_dashboard_resources to rmf_demos_dashboard_resources

Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>

* update all namings with rmf_demos as prefix (#1)

Signed-off-by: youliang <tan_you_liang@hotmail.com>

* Match renamed packages (#4)

Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>

* Add priority selection in dispatch scripts and react ui (#5)

* add priority selection in dispatch scripts and react ui

Signed-off-by: youliang <tan_you_liang@hotmail.com>

* clean package.xml

Signed-off-by: youliang <tan_you_liang@hotmail.com>

* Feature/setup ci (#7)

* add ci for rmf_demos and remove npm build dep

Signed-off-by: youliang <tan_you_liang@hotmail.com>

* clean up CI

Signed-off-by: youliang <tan_you_liang@hotmail.com>

* added missing commit on download fn

Signed-off-by: youliang <tan_you_liang@hotmail.com>

* minor cleanups and update according to feedback

Signed-off-by: youliang <tan_you_liang@hotmail.com>

Co-authored-by: Yadunund <yadunund@openrobotics.org>
Co-authored-by: Aaron Chong <aaronchongth@gmail.com>
Co-authored-by: ngwk1 <52265866+ngwk1@users.noreply.github.com>
Co-authored-by: Charayaphan Nakorn Boon Han <cnboonhan94@gmail.com>
Co-authored-by: koonpeng <koonpeng@openrobotics.org>
Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Co-authored-by: Marco A. Gutierrez <marcogg@marcogg.com>
Co-authored-by: Morgan Quigley <morgan@osrfoundation.org>
Co-authored-by: Marco A. Gutiérrez <marco@openrobotics.org>
Co-authored-by: Matias Bavera <matiasbavera@gmail.com>
Co-authored-by: kevinskwk <kevinskwk@gmail.com>
Co-authored-by: Kevin_Skywalker <50894569+Kevinskwk@users.noreply.github.com>
Co-authored-by: mrushyendra <mrushyendra@yahoo.com.sg>
Co-authored-by: MakinoharaShouko <qianj4@uw.edu>
Co-authored-by: MakinoharaShouko <57300801+MakinoharaShouko@users.noreply.github.com>
Co-authored-by: Michael X. Grey <grey@openrobotics.org>
Co-authored-by: Luca Della Vedova <luca@openrobotics.org>
Co-authored-by: ddengster <liangdeng.fan@gmail.com>
Co-authored-by: Valerie <valeriebuilds@gmail.com>
Co-authored-by: vallq <vallq@outlook.com>
Co-authored-by: Arjo Chakravarty <arjo@openrobotics.org>
@Yadunund Yadunund closed this as completed Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants