Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start using ros-tooling for build and test workflow, added coverage, tsan #14

Merged
merged 11 commits into from
May 21, 2021
Merged

Start using ros-tooling for build and test workflow, added coverage, tsan #14

merged 11 commits into from
May 21, 2021

Conversation

aaronchongth
Copy link
Member

@aaronchongth aaronchongth commented Apr 26, 2021 •
edited
Loading

Signed-off-by: Aaron Chong aaronchongth@gmail.com

New feature implementation

Implemented feature

  • Added coverage workflow, coverage-gcc
  • Added thread sanitization workflow, tsan
  • Using clang, Debug build and tsan colcon mixin.
  • Fixed errors that arise when compiling with clang.

@codecov
Copy link

codecov bot commented Apr 26, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@7492d42). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             main     #14   +/-   ##
======================================
  Coverage        ?   0.00%           
======================================
  Files           ?      46           
  Lines           ?    3752           
  Branches        ?       0           
======================================
  Hits            ?       0           
  Misses          ?    3752           
  Partials        ?       0
Flag Coverage Δ
tests 0.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mxgrey mxgrey requested a review from gbiggs April 29, 2021 03:05
@ddengster ddengster mentioned this pull request May 12, 2021
Closed
@aaronchongth
Using ros-tooling action ci, added coverage and tsan
5bb7751 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Fix broken pipe error
586dbcc 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Using newline to separate packages
cd40e17 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Reverted to using basic coverage-gcc workflow, added tsan workflow
2b77dc8 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Renamed job to tsan, added clang environment variables
0ad5ee2 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Adding upload_artifact step in tsan workflow
72ffc06 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Fixed copy of non-trivial type, using c_str() instead of std::string
ae30f8e 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Fixed unused template keywords due to API not templated
c025f37 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Adding codecov.yml file
801cd2b 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
gbiggs
gbiggs reviewed May 19, 2021
View reviewed changes
.github/workflows/tsan.yaml Outdated Show resolved Hide resolved
@aaronchongth
Removed tsan workflow on push
ac54875 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth requested a review from gbiggs May 20, 2021 02:25
@aaronchongth aaronchongth enabled auto-merge (squash) May 20, 2021 06:22
@aaronchongth
Added cron job for both build and tsan, fixed upload artifact targets
390b820 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth merged commit 5a0fee5 into main May 21, 2021
@aaronchongth aaronchongth deleted the ci/coverage-and-tsan branch May 21, 2021 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbiggs gbiggs gbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronchongth @gbiggs