Skip to content

Conversation

@shanejonas
Copy link
Member

@shanejonas shanejonas commented Nov 30, 2020

fixes a bug where it would mutate the underlying .params array instead of copying a new one

@codecov
Copy link

codecov bot commented Nov 30, 2020

Codecov Report

Merging #405 (81d33e0) into master (8409305) will increase coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
+ Coverage   97.25%   97.52%   +0.26%     
==========================================
  Files          16       16              
  Lines         364      363       -1     
  Branches       86       86              
==========================================
  Hits          354      354              
+ Misses          3        2       -1     
  Partials        7        7              
Impacted Files Coverage Δ
src/Documentation.tsx 100.00% <ø> (+7.69%) ⬆️
src/ExamplePairings/ExamplePairings.tsx 97.87% <100.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8409305...81d33e0. Read the comment docs.

@shanejonas shanejonas force-pushed the fix/object-assign-reuse branch from a4f019a to 623589a Compare November 30, 2020 20:27
@shanejonas shanejonas self-assigned this Dec 1, 2020
@shanejonas shanejonas closed this Dec 1, 2020
@shanejonas shanejonas reopened this Dec 1, 2020
@shanejonas shanejonas added the bug Something isn't working label Dec 1, 2020
@shanejonas shanejonas merged commit e793378 into master Dec 1, 2020
@shanejonas shanejonas deleted the fix/object-assign-reuse branch December 1, 2020 17:54
@openrpc-bastion
Copy link
Member

🎉 This PR is included in version 1.2.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants