fix(JSON Schema): nested items/objects and oneOf #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
==========================================
+ Coverage 91.25% 92.19% +0.94%
==========================================
Files 16 16
Lines 343 346 +3
Branches 81 82 +1
==========================================
+ Hits 313 319 +6
+ Misses 16 13 -3
Partials 14 14
Continue to review full report at Codecov.
|
zcstarr
approved these changes
May 7, 2019
Member
zcstarr
left a comment
zcstarr
left a comment
There was a problem hiding this comment.
🐑 lgtm. One non blocking comment, is that eventually ux wise, if I'm looking at the code correctly we'll need to limit the number of levels nested ( visually) . Or alternatively have an eventual re-think of the ux. I think this patch will make a big difference for people trying to use the playground! Nice!
Member
Author
|
🎉 This PR is included in version 1.0.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #71
fixes #72
fixes #73
complex array items
nested objects
better one of support