Commit bcd9ffb
committed
fix(grpc): Address P1 code review issues - restore error_details export and fix deprecated Server constructor
ISSUE 1 - Missing error_details Export:
- Re-export generated/google/rpc/error_details.pb.dart from lib/grpc.dart
- Prevents breaking downstream code expecting BadRequest and other google.rpc error messages
- Addresses: #8 (comment)
ISSUE 2 - Deprecated Server Constructor Argument Order:
- Fix argument forwarding in deprecated Server(...) constructor
- Insert empty serverInterceptors list in super() call to maintain correct parameter positions
- Prevents codecRegistry/errorHandler from being passed to wrong slots
- Maintains backwards compatibility for existing code using deprecated constructor
- Addresses: #8 (comment)
VERIFICATION:
- dart analyze: ✅ No issues
- dart test: ✅ All 172 tests passing (+3 skipped)
- dart format: ✅ Properly formatted
- No breaking changes - fully backwards compatible
RELATED:
- PR: #8
- Codex review comments resolved1 parent b19355f commit bcd9ffb
2 files changed
+16
-6
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| 42 | + | |
42 | 43 | | |
43 | 44 | | |
44 | 45 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
200 | 200 | | |
201 | 201 | | |
202 | 202 | | |
203 | | - | |
204 | | - | |
205 | | - | |
206 | | - | |
207 | | - | |
208 | | - | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
209 | 218 | | |
210 | 219 | | |
211 | 220 | | |
| |||
0 commit comments