Repository setup #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldadfux
reviewed
Feb 15, 2022
eldadfux
reviewed
Nov 3, 2022
Member
eldadfux
left a comment
eldadfux
left a comment
There was a problem hiding this comment.
Looks great. We might need to have the source files for the test functions so we can easily update and repackage them in the future. Still haven't reviewed the http server, waiting for you to complete it.
christyjacob4
commented
Nov 5, 2022
Co-authored-by: Matej Bačo <matejbaco2000@gmail.com>
Co-authored-by: Matej Bačo <matejbaco2000@gmail.com>
Co-authored-by: Matej Bačo <matejbaco2000@gmail.com>
feat: add support for new DSN string
eldadfux
previously requested changes
Nov 5, 2022
Co-authored-by: Eldad A. Fux <eldad.fux@gmail.com>
Meldiron
reviewed
Nov 6, 2022
Feat: improve health structure
christyjacob4
commented
Nov 8, 2022
Contributor
Author
christyjacob4
left a comment
christyjacob4
left a comment
There was a problem hiding this comment.
Looks good 👍
Meldiron
approved these changes
Nov 8, 2022
christyjacob4
dismissed
eldadfux’s stale review
All comments are resolved. If there are any further comments we can release a new version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.