Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: title for PR chart tooltip #3350

Merged
merged 2 commits into from
May 10, 2024
Merged

fix: title for PR chart tooltip #3350

merged 2 commits into from
May 10, 2024

Conversation

Idrinth
Copy link
Contributor

@Idrinth Idrinth commented May 9, 2024

Description

This PR fixes the title text for pull request charts.

Related Tickets & Documents

fixes #3349

Mobile & Desktop Screenshots/Recordings

Steps to QA

  1. Visit a repository page
  2. Hover over the PR-Chart
  3. Validate you see the right title

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

7adbba2a7c23322e6faae4e475dd9786

Copy link

netlify bot commented May 9, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit 940a06c
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/663d82a2c8df4b0007c27248
😎 Deploy Preview https://deploy-preview-3350--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

Copy link

netlify bot commented May 9, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit 940a06c
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/663d82a2bdb2c900089a4b51
😎 Deploy Preview https://deploy-preview-3350--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Idrinth Idrinth changed the title fix title for prchart tooltip fix: title for prchart tooltip May 9, 2024
@nickytonline nickytonline changed the title fix: title for prchart tooltip fix: title for PR chart tooltip May 9, 2024
Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Idrinth!

:shipit:

Copy link
Contributor

@zeucapua zeucapua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @Idrinth, LGTM!

@zeucapua zeucapua merged commit 56b2746 into open-sauced:beta May 10, 2024
11 checks passed
open-sauced bot pushed a commit that referenced this pull request May 10, 2024
## [2.26.1-beta.1](v2.26.0...v2.26.1-beta.1) (2024-05-10)

### 🐛 Bug Fixes

* title for PR chart tooltip ([#3350](#3350)) ([56b2746](56b2746))
open-sauced bot pushed a commit that referenced this pull request May 15, 2024
## [2.27.0](v2.26.0...v2.27.0) (2024-05-15)

### 🍕 Features

* Contributors tab for Repo pages ([#3342](#3342)) ([f1142c3](f1142c3))
* Lottery Factor chart for Repo pages ([#3343](#3343)) ([deda50e](deda50e))

### 🐛 Bug Fixes

* now opening workspace dropdown puts focus on search input ([#3364](#3364)) ([bafa0e4](bafa0e4))
* now StarSearch remains visible on smaller screens in the top menu ([#3374](#3374)) ([d6d0048](d6d0048))
* temporarily returning for event: function_call in readable stream from StarSearch ([#3379](#3379)) ([f6f4b01](f6f4b01))
* title for PR chart tooltip ([#3350](#3350)) ([56b2746](56b2746))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: wrong tooltip title for PRChart in Repo pages
3 participants