feat: Adds image and instructions on how to get DevCard page by Haimantika · Pull Request #234 · open-sauced/docs

Haimantika · 2023-12-27T13:33:12Z

Description

This PR adds image and instructions on how to get DevCard page

What type of PR is this? (check all applicable)

Related Tickets & Documents

Fixes #222

Mobile & Desktop Screenshots/Recordings

Steps to QA

NA

Added to documentation?

📜 README.md
[] 📓 docs.opensauced.pizza
🍕 dev.to/opensauced
📕 storybook
🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify · 2023-12-27T13:33:14Z

👷 Deploy request for docs-open pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	`247f9f4`

github-actions

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Lymah123 · 2023-12-27T19:45:34Z

Hi @Haimantika, well done. Thanks for working on this issue.

@BekahHW is not currently available. She will review and give feedback once she is available.

Pending that time, I will tag other maintainers to review the PR.

@CBID2 and @adiati98, @Haimantika awaits your feedback. Thank you!

docs/features/dev-card.md

CBID2

Hi @Haimantika! :) Your PR is off to a great start! :) I just gave a tip to improve it. :)

CBID2 · 2023-12-27T20:18:08Z

Hi @Haimantika, well done. Thanks for working on this issue.

@BekahHW is not currently available. She will review and give feedback once she is available.

Pending that time, I will tag other maintainers to review the PR.

@CBID2 and @adiati98, @Haimantika awaits your feedback. Thank you!

Thanks for pinging me @Lymah123! :) I just gave some feedback! :)

Lymah123 · 2023-12-28T01:07:17Z

Hi @Haimantika, well done. Thanks for working on this issue.
@BekahHW is not currently available. She will review and give feedback once she is available.
Pending that time, I will tag other maintainers to review the PR.
@CBID2 and @adiati98, @Haimantika awaits your feedback. Thank you!

Thanks for pinging me @Lymah123! :) I just gave some feedback! :)

Thank you for the prompt response. @CBID2!

Haimantika · 2023-12-28T07:42:53Z

Hi @Haimantika, well done. Thanks for working on this issue.
@BekahHW is not currently available. She will review and give feedback once she is available.
Pending that time, I will tag other maintainers to review the PR.
@CBID2 and @adiati98, @Haimantika awaits your feedback. Thank you!

Thanks for pinging me @Lymah123! :) I just gave some feedback! :)

Thanks @CBID2 :D
I have hyperlinked the image in the third point, let me know if you want me to structure it differently.

adiati98

@Haimantika thank you for the changes! I left some reviews here for you. 😊

Also, I run your branch locally, and the link to the image leads to "Page Not Found" as screen recording below:

I see in the "files changed" tab that .svg is unabled to render because it's an invalid image source.

I would love to have confirmation from @BekahHW if we should use .png instead for the image like other images in the static folder.

Once Bekah confirmed, let's use Bekah's image here as it already has good size and arrow pointing to the card. You can download Bekah's image on the issue by following these steps:

Right click on the image.
Click "Save image as..."
Save the image as get-dev-card.png.

Please let me know if you can't dowload it, so I can help you with it. Thanks!

docs/features/dev-card.md

Haimantika · 2023-12-28T11:06:01Z

@Haimantika thank you for the changes! I left some reviews here for you. 😊

Also, I run your branch locally, and the link to the image leads to "Page Not Found" as screen recording below:

I see in the "files changed" tab that .svg is unabled to render because it's an invalid image source.

I would love to have confirmation from @BekahHW if we should use .png instead for the image like other images in the static folder.

Once Bekah confirmed, let's use Bekah's image here as it already has good size and arrow pointing to the card. You can download Bekah's image on the issue by following these steps:

Right click on the image.

Click "Save image as..."

Save the image as get-dev-card.png.

Please let me know if you can't dowload it, so I can help you with it. Thanks!

Hi, thanks for the feedback. The image is not getting downloaded after multiple tries.

Co-authored-by: Ayu Adiati <45172775+adiati98@users.noreply.github.com>

BekahHW · 2024-01-04T19:16:32Z

Apologies for just coming into this. I was off for Christmas and I'm trying to catch up.

Thanks everyone for the help.

@Haimantika, apologies for the confusion with the SVG v. png. Please save it as a png if that works. You'll need to generate the image yourself or save the image by right clicking and choosing save image as. From there, you'll add the image to the file path specific in the issue.

docs/features/dev-card.md

Co-authored-by: Ayu Adiati <45172775+adiati98@users.noreply.github.com>

Haimantika · 2024-01-05T06:10:11Z

Thanks @BekahHW. @adiati98 I have accepted your change, let me know if anything else is needed from my end.

adiati98

@Haimantika thank you for the changes! LGTM! 🙌

## [1.60.0](v1.59.0...v1.60.0) (2024-01-05) ### Features * Adds image and instructions on how to get DevCard page ([#234](#234)) ([b358c27](b358c27))

github-actions · 2024-01-05T10:54:50Z

🎉 This PR is included in version 1.60.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

* Added dev card details * Added the image link * Made changes Co-authored-by: Ayu Adiati <45172775+adiati98@users.noreply.github.com> * fix: remove get_dev_card.svg * feat: add get-dev-card.png * Update docs/features/dev-card.md Co-authored-by: Ayu Adiati <45172775+adiati98@users.noreply.github.com> --------- Co-authored-by: Haimantika Mitra <haimantikamitra@Haimantikas-MacBook-Pro.local> Co-authored-by: Ayu Adiati <45172775+adiati98@users.noreply.github.com> Co-authored-by: Ayu Adiati <retno.ayu98@gmail.com> b358c27

Added dev card details

4639bdf

github-actions bot reviewed Dec 27, 2023

View reviewed changes

Haimantika changed the title ~~Added dev card details~~ Feat: Adds image and instructions on how to DevCard page Dec 27, 2023

Haimantika changed the title ~~Feat: Adds image and instructions on how to DevCard page~~ feat: Adds image and instructions on how to DevCard page Dec 27, 2023

Haimantika changed the title ~~feat: Adds image and instructions on how to DevCard page~~ feat: Adds image and instructions on how to get DevCard page Dec 27, 2023

CBID2 assigned Haimantika Dec 27, 2023

CBID2 added 💡 feature A label to note if work is a feature 📝 documentation good first issue labels Dec 27, 2023

CBID2 reviewed Dec 27, 2023

View reviewed changes

docs/features/dev-card.md Outdated Show resolved Hide resolved

CBID2 suggested changes Dec 27, 2023

View reviewed changes

Added the image link

5f69e86

adiati98 requested changes Dec 28, 2023

View reviewed changes

docs/features/dev-card.md Outdated Show resolved Hide resolved

Made changes

1c431af

Co-authored-by: Ayu Adiati <45172775+adiati98@users.noreply.github.com>

adiati98 added 2 commits January 4, 2024 21:57

fix: remove get_dev_card.svg

0295f14

feat: add get-dev-card.png

9ac3438

adiati98 reviewed Jan 4, 2024

View reviewed changes

docs/features/dev-card.md Outdated Show resolved Hide resolved

Update docs/features/dev-card.md

247f9f4

Co-authored-by: Ayu Adiati <45172775+adiati98@users.noreply.github.com>

adiati98 approved these changes Jan 5, 2024

View reviewed changes

adiati98 merged commit b358c27 into open-sauced:main Jan 5, 2024

github-actions bot pushed a commit that referenced this pull request Jan 5, 2024

chore(release): 1.60.0 [skip ci]

a7b4fea

## [1.60.0](v1.59.0...v1.60.0) (2024-01-05) ### Features * Adds image and instructions on how to get DevCard page ([#234](#234)) ([b358c27](b358c27))

github-actions bot added the released label Jan 5, 2024

Conversation

Haimantika commented Dec 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

What type of PR is this? (check all applicable)

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Steps to QA

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Uh oh!

netlify bot commented Dec 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👷 Deploy request for docs-open pending review.

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

PR Compliance Checks

Issue Reference

Uh oh!

Lymah123 commented Dec 27, 2023

Uh oh!

Uh oh!

CBID2 left a comment

Choose a reason for hiding this comment

Uh oh!

CBID2 commented Dec 27, 2023

Uh oh!

Lymah123 commented Dec 28, 2023

Uh oh!

Haimantika commented Dec 28, 2023

Uh oh!

adiati98 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Haimantika commented Dec 28, 2023

Uh oh!

BekahHW commented Jan 4, 2024

Uh oh!

Uh oh!

Haimantika commented Jan 5, 2024

Uh oh!

adiati98 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Haimantika commented Dec 27, 2023 •

edited

Loading

netlify bot commented Dec 27, 2023 •

edited

Loading

github-actions bot left a comment •

edited

Loading

adiati98 left a comment •

edited

Loading