Skip to content

Conversation

@catherinechiu
Copy link
Contributor

Types of changes

  • Bugfix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Refactor (change which changes the codebase without affecting its external behavior)
  • Non-breaking change (fix or feature that would causes existing functionality to work as expected)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Purpose

  • The MVP will only be running off one database that is containerized in Docker. In stretch, we will add a feature to create new schemas, which will spin up a separate Postgres instance for each schema. We do not need to edit schema for MVP.
  • Deliver the most important analytics for each query in a concise and readable format. This is displayed in the Results panel.
  • Enhance the user experience by allowing them to write all their query and schema code in-app rather than having to open a separate code editor to see syntax highlighting.
  • Keep code DRY and minimal
  • Fix Typescript bugs

Approach

  • Commented out edit schema button to use for stretch features
  • Created dynamically rendered Results panel to update with executed query results data that will be received from backend
  • Added code editor with syntax highlighting for SQL and line numbers
  • Deleted unused variables
  • Changed type for 'queries' in MainPanel.tsx to 'any.' Refactor to specific type in future PR.

Resources

Codmirror Example
Electron & Codemirror
Kill :5432 Before Running App

Screenshot(s)

In-App Code Editor
Screen Shot 2020-08-20 at 1 41 31 PM

Dynamic Results Table
Screen Shot 2020-08-20 at 1 45 20 PM

mstronck and others added 2 commits August 20, 2020 14:49
Create frontend interface for displaying history from queries, refactor & update sass
Copy link
Contributor

@muhammadtrad muhammadtrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great on my machine!

Copy link
Contributor

@serenackuo serenackuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code window looks and functions great! Everything else is looking stellar.

@catherinechiu catherinechiu merged commit 0e02e3a into open-source-labs:staging Aug 20, 2020
frakes413 added a commit to frakes413/SeeQR that referenced this pull request Oct 3, 2020
chrisakinrinade pushed a commit that referenced this pull request Jan 7, 2021
cindychau added a commit that referenced this pull request Feb 25, 2021
first round of refactorings while studying component tree
JBradbeer pushed a commit that referenced this pull request Apr 28, 2022
Frynoceros pushed a commit that referenced this pull request Aug 4, 2022
Hiya-its-Aya pushed a commit that referenced this pull request Feb 23, 2023
getLists & getTable errors fixed
junaid-ahmed7 pushed a commit that referenced this pull request Apr 20, 2023
updated package.json and readme to reference v10
haemie added a commit that referenced this pull request Jul 7, 2023
derekoko pushed a commit that referenced this pull request Aug 24, 2023
lovelyjoy1991 pushed a commit that referenced this pull request Jun 5, 2024
`docs: Update DEV_README for V14.0.0, add comments and clean code base`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants