Skip to content

Conversation

@trask
Copy link
Member

@trask trask commented Oct 26, 2024

hasAttributesSatisfying(Attributes::isEmpty))) always passes since isEmpty() never throws an exception

@github-actions github-actions bot added the test native This label can be applied to PRs to trigger them to run native tests label Oct 26, 2024
@trask trask force-pushed the fix-some-assertions branch 4 times, most recently from c1a16c2 to 46be9b8 Compare October 26, 2024 19:35
@trask trask force-pushed the fix-some-assertions branch from 46be9b8 to 5b1df04 Compare October 26, 2024 20:38
@trask trask marked this pull request as ready for review October 26, 2024 21:22
@trask trask requested a review from a team as a code owner October 26, 2024 21:22
Copy link
Member

@jaydeluca jaydeluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@trask trask merged commit bb90e08 into open-telemetry:main Oct 26, 2024
56 checks passed
@trask trask deleted the fix-some-assertions branch October 26, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test native This label can be applied to PRs to trigger them to run native tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants