Ratpack strict context check #4367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
26 tasks
iNikem
reviewed
Oct 13, 2021
| return delegate; | ||
| } | ||
| Context context = Context.current(); | ||
| if (context == Context.root()) { |
There was a problem hiding this comment.
Can you add some comment to explain why wrapping actions depend on the context being root or not?
There was a problem hiding this comment.
I'll add a comment, the reasoning is described here
mateuszrzeszutek
approved these changes
Oct 13, 2021
trask
approved these changes
Oct 13, 2021
iNikem
approved these changes
Oct 14, 2021
|
This pr depends on #4380 because ratpack tests are not spock tests and are flaky because of strict context checks. |
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
* Ratpack strict context check * Add comment, remove logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3916