feat: Respect "suppress_instrumentation" in redis instrumentor

[martimors]

Description

Fixes #2057

I'll wait until I get some feedback to update the changelog and the docs if need be.

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Manual test
• Unit test

Does This PR Require a Core Repo Change?

• Yes. - Link to PR:
• No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

• Followed the style guidelines of this project
• Changelogs have been updated
• Unit tests have been added
• Documentation has been updated

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: martimors / name: Martin Morset (f60a669, 201470f, aac4f7a, 1744eba, a6260a2, eed93aa, 4075173, 20b551e, 1ff4c0b, 8d8eb6f)
• ✅ login: xrmx / name: Riccardo Magliocchetti (2677a7e)
• ✅ login: ocelotl / name: Diego Hurtado (88f1b9a)

[federicobond]

There is a function called is_instrumentation_enabled in the opentelemetry.instrumentation.utils module that should be used instead of accessing _SUPRESS_INSTRUMENTATION_KEY directly.

[martimors]

Thanks, I've addressed this. I'd like to run the tests but I can't figure out how to do so, the tox command just goes into an error loop (MacOS). Can you help?

[federicobond]

Without knowing what arguments you are passing and what error you are getting it's hard to give any specific suggestion.

[martimors]

No arguments, #2330

[martimors]

Sorry for the commit spam - I'm just reviewing myself as best I can while not being able to run the tests locally. Do you have some guide how to get that up and running, preferably in the IDE and not tox on the cli? That would make this development experience a lot better for me.

[martimors]

@federicobond are we good to go here?

[ocelotl]

@martimors please take a look at the failures. The only way we can run tests is by using tox, which actually will create a virtual environment with all the testing dependencies installed and the pytest will run the tests.

[emdneto]

Closing in favor of #3955