-
Notifications
You must be signed in to change notification settings - Fork 759
Implement partial success logging in OTLP exporters #4805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Implement partial success logging in OTLP exporters #4805
Conversation
…levels to avoid changing default behaviors. Apply test and formatting fixes.
This appears to cause an issue with "tox -e docs".
DylanRussell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why put this log behind an env var ? Why not just always log when the field is set -- I'm assuming it's only set when there was a partial success -- it doesn't sound too noisy to me.
I'm uncertain as to the level of noisiness, and so I wanted to minimize disruption to existing users. I could imagine it being somewhat annoying if every batch included one persistently malformed span that just ended up creating log spam. A more sophisticated approach might be to opt-in to recording every partial success, while elevating the verbosity and logging the partial success unconditionally if every record was a failure (if |
|
We already have the I think it's a bit weird to put just 1 log message behind this env var |
Log partial success based on
$OTEL_LOG_LEVELWhen
$OTEL_LOG_LEVELisverboseordebug, partially succeeding responses will be logged.Fixes #4803
Type of change
How Has This Been Tested?
Added new unit tests covering the relevant cases.
Does This PR Require a Contrib Repo Change?
Checklist: