-
Notifications
You must be signed in to change notification settings - Fork 598
Description
Experimental attribute network.interface.name
opentelemetry-rust/opentelemetry-semantic-conventions/src/attribute.rs
Lines 4940 to 4943 in 6a8db83
| /// | |
| /// - `"lo"` | |
| /// - `"eth0"` | |
| pub const NETWORK_INTERFACE_NAME: &str = "network.interface.name"; |
does not have #[cfg(feature = "semconv_experimental")]
It happens because of open-telemetry/semantic-conventions#1777 - this attribute slipped into 1.29.0 semconv without stability set. It's fixed on semconv side and we added checks that would prevent it in the future.
So it should be fixed with the new version of semantic conventions (1.30.0 is coming out in the next few days).
In any case, it'd be best to update this jinja template
Lines 17 to 19 in 6a8db83
| {% if attr is experimental %} | |
| #[cfg(feature = "semconv_experimental")] | |
| {% endif %} |
to
{% if attr is not stable %}
#[cfg(feature = "semconv_experimental")]
{% endif %}to make sure we add semconv_experimental to everything that's not stable.
(the same pattern is used in metrics, resources, and trace templates)
It seems that semconv artifact is not stable, so it should be ok to do a breaking change.
This attribute is very new and very unlikely to be used by anyone.