Use different template to have unit tests #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After take a detailed look at the 3 apps in the template, I found that you can't just simply use a generic template for them all.
Because these are different apps, one is java, one is php, and the third is nodejs, for Java and php app, if we want to have the unit tests and code coverage, we might have to run our own unit tests (previously we only have functional verification tests for these two apps, but we dont deploy anything now in their own pipeline, so we can't do fvt until the CD pipeline)
Thus, I create two more yaml files and update them all with the "Publish Componenet Chart Checks" gate before publishing component chart checks.
Also I made a fix for the catalog api template unit test, the PR is open-toolchain/Microservices_CatalogAPI_helm#1