docs: refine recommended paths defaults (composer.json, drop tests filter)#7
Merged
Merged
Conversation
- composer.json should be on every PHP linter caller (the linters run through composer scripts, so composer.json changes can affect behavior); composer.lock too for anything that runs composer install - tests.yml should NOT have a paths filter — tests depend on too many runtime assets to safely enumerate, and the cost of missing a test failure exceeds the cost of running tests on a docs-only PR Caught by Copilot on oce-module-sinch-conversations#132.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refines the recommended caller paths-filter patterns based on issues Copilot caught on oce-module-sinch-conversations#132:
composer.json(andcomposer.lockfor anything that runscomposer install). The linters are invoked through composer scripts (composer phpstan,composer phpcs,composer php-lint, etc.), so a change tocomposer.jsoncan change what runs. The earlier defaults missed this on phpcs and php-syntax-check.tests.ymlshould NOT have a paths filter. Tests depend on too many runtime assets — Twig templates, SQL, config, fixtures — to safely enumerate. The runner cost of running tests on a docs-only PR is much smaller than the cost of not running them when an asset that affects them changed.The reusables themselves are unchanged. This PR only updates header comments and the README; existing callers continue to work.