fix: Cannot select the document for identifiers.

refactor

Author: AathmanT

mifosng-android/src/main/java/com/mifos/mifosxdroid/dialogfragments/documentdialog/DocumentDialogFragment.java

@@ -134,6 +134,7 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle
             tvDocumentAction.setText(R.string.upload_document);
         }
 
+        btUpload.setEnabled(false);
         return rootView;
     }
 
@@ -317,6 +318,11 @@ public void showError(int errorMessage) {
         Toast.makeText(getActivity(), getString(errorMessage), Toast.LENGTH_SHORT).show();
         getDialog().dismiss();
     }
+    @Override
+    public void showUploadError(String errorMessage) {
+        Toast.makeText(getActivity(), errorMessage, Toast.LENGTH_SHORT).show();
+        getDialog().dismiss();
+    }
 
     @Override
     public void showProgressbar(boolean b) {

mifosng-android/src/main/java/com/mifos/mifosxdroid/dialogfragments/documentdialog/DocumentDialogMvpView.java

@@ -19,4 +19,6 @@ public interface DocumentDialogMvpView extends MvpView {
     void showDocumentUpdatedSuccessfully();
 
     void showError(int errorMessage);
+
+    void showUploadError(String errorMessage);
 }

mifosng-android/src/main/java/com/mifos/mifosxdroid/dialogfragments/documentdialog/DocumentDialogPresenter.java

@@ -4,6 +4,7 @@
 import com.mifos.api.datamanager.DataManagerDocument;
 import com.mifos.mifosxdroid.R;
 import com.mifos.mifosxdroid.base.BasePresenter;
+import com.mifos.utils.MFErrorParser;
 
 import java.io.File;
 
@@ -12,8 +13,10 @@
 import okhttp3.MediaType;
 import okhttp3.MultipartBody.Part;
 import okhttp3.RequestBody;
+import retrofit2.adapter.rxjava.HttpException;
 import rx.Subscriber;
 import rx.android.schedulers.AndroidSchedulers;
+import rx.plugins.RxJavaPlugins;
 import rx.schedulers.Schedulers;
 import rx.subscriptions.CompositeSubscription;
 
@@ -58,7 +61,19 @@ public void onCompleted() {
                     @Override
                     public void onError(Throwable e) {
                         getMvpView().showProgressbar(false);
-                        getMvpView().showError(R.string.failed_to_upload_document);
+                        String errorMessage;
+                        try {
+                            if (e instanceof HttpException) {
+                                errorMessage = ((HttpException) e).response().errorBody().string();
+                                getMvpView().showUploadError(MFErrorParser.parseError(errorMessage)
+                                        .getDeveloperMessage());
+                            } else {
+                                getMvpView().showError(R.string.failed_to_upload_document);
+                            }
+                        } catch (Throwable throwable) {
+                                RxJavaPlugins.getInstance().getErrorHandler()
+                                        .handleError(throwable);
+                        }
                     }
 
                     @Override

mifosng-android/src/main/res/layout/dialog_fragment_document.xml

@@ -17,7 +17,7 @@
 
     <LinearLayout
         android:layout_height="wrap_content"
-        android:layout_width="match_parent"
+        android:layout_width="wrap_content"
         android:orientation="vertical">
 
         <TextView
@@ -68,7 +68,7 @@
         </android.support.design.widget.TextInputLayout>
 
 
-            <android.support.design.widget.TextInputLayout
+        <android.support.design.widget.TextInputLayout
                 android:id="@+id/til_selected_file"
                 android:gravity="center"
                 android:layout_height="match_parent"