Add tests for Agent default model settings when using GPT-5 #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

seratch merged 1 commit into main from codex/add-unit-tests-for-pr-#1534

Aug 23, 2025

+22 −3

Member

seratch commented Aug 23, 2025

Summary

test Agent inherits GPT-5 default model settings
ensure non-GPT-5 models reset default GPT-5 settings

Testing

make format
make lint
make mypy
OPENAI_API_KEY=dummy make tests

https://chatgpt.com/codex/tasks/task_i_68a92726d6bc83208337e5b8c2228631


          test: cover agent default model settings for gpt-5

633239d

seratch added the codex label

— with

ChatGPT Codex Connector

seratch added the feature:core label

seratch merged commit 11b1c1e into main

7 checks passed

seratch deleted the codex/add-unit-tests-for-pr-#1534 branch

August 23, 2025 03:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex feature:core