Skip to content

Add tests for Agent default model settings when using GPT-5 #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2025
Merged

Add tests for Agent default model settings when using GPT-5 #1562

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions tests/models/test_default_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import os
from unittest.mock import patch

from agents import Agent
from agents.model_settings import ModelSettings
from agents.models import (
get_default_model,
get_default_model_settings,
Expand All @@ -21,23 +23,23 @@ def test_default_model_env_gpt_5():
assert get_default_model() == "gpt-5"
assert is_gpt_5_default() is True
assert gpt_5_reasoning_settings_required(get_default_model()) is True
assert get_default_model_settings().reasoning.effort == "low" # type: ignore [union-attr]
assert get_default_model_settings().reasoning.effort == "low" # type: ignore[union-attr]


@patch.dict(os.environ, {"OPENAI_DEFAULT_MODEL": "gpt-5-mini"})
def test_default_model_env_gpt_5_mini():
assert get_default_model() == "gpt-5-mini"
assert is_gpt_5_default() is True
assert gpt_5_reasoning_settings_required(get_default_model()) is True
assert get_default_model_settings().reasoning.effort == "low" # type: ignore [union-attr]
assert get_default_model_settings().reasoning.effort == "low" # type: ignore[union-attr]


@patch.dict(os.environ, {"OPENAI_DEFAULT_MODEL": "gpt-5-nano"})
def test_default_model_env_gpt_5_nano():
assert get_default_model() == "gpt-5-nano"
assert is_gpt_5_default() is True
assert gpt_5_reasoning_settings_required(get_default_model()) is True
assert get_default_model_settings().reasoning.effort == "low" # type: ignore [union-attr]
assert get_default_model_settings().reasoning.effort == "low" # type: ignore[union-attr]


@patch.dict(os.environ, {"OPENAI_DEFAULT_MODEL": "gpt-5-chat-latest"})
Expand All @@ -54,3 +56,20 @@ def test_default_model_env_gpt_4o():
assert is_gpt_5_default() is False
assert gpt_5_reasoning_settings_required(get_default_model()) is False
assert get_default_model_settings().reasoning is None


@patch.dict(os.environ, {"OPENAI_DEFAULT_MODEL": "gpt-5"})
def test_agent_uses_gpt_5_default_model_settings():
"""Agent should inherit GPT-5 default model settings."""
agent = Agent(name="test")
assert agent.model is None
assert agent.model_settings.reasoning.effort == "low" # type: ignore[union-attr]
assert agent.model_settings.verbosity == "low"


@patch.dict(os.environ, {"OPENAI_DEFAULT_MODEL": "gpt-5"})
def test_agent_resets_model_settings_for_non_gpt_5_models():
"""Agent should reset default GPT-5 settings when using a non-GPT-5 model."""
agent = Agent(name="test", model="gpt-4o")
assert agent.model == "gpt-4o"
assert agent.model_settings == ModelSettings()