fix(reqLogger): prevent destroyed socket race

[jasisk]

Always set the socket response type to finished when finished is called. Prevents a race where finished sockets sometimes get logged as destroyed (since all sockets are eventually destroyed, even when they sent a response successfully).

[Copilot]

Pull Request Overview

This PR fixes a race condition in the request logger where the destroyed socket state could be incorrectly reported when a request finished successfully. The fix introduces a SUCCESS_SEMAPHORE symbol to explicitly track when a response has finished successfully, allowing the logger to distinguish between a completed response and a destroyed socket.

Key changes:

• Added SUCCESS_SEMAPHORE symbol to track successful response completion
• Modified response type detection logic to check for successful finish before checking for destroyed/aborted states
• Updated quote style from single quotes to double quotes throughout the file

Comments suppressed due to low confidence (1)

src/telemetry/requestLogger.ts:74

• The Response type definition in the finishLog function signature is missing the SUCCESS_SEMAPHORE property. Since res[SUCCESS_SEMAPHORE] is accessed at line 99, this property should be added to the type definition to maintain type safety. Update the type to: res: Response & { [LOGGED_SEMAPHORE]?: boolean; [SUCCESS_SEMAPHORE]?: boolean }

  res: Response & { [LOGGED_SEMAPHORE]?: boolean },

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

🎉 This PR is included in version 6.2.1 🎉

The release is available on:

• v6.2.1
• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀