OBLS-284 allow to update barcode, send notification about update #5597
Conversation
github-actions
bot
added
domain: frontend
olewandowski1
changed the title
| action = [GET: "details"] | ||
| } | ||
|
|
||
| "/api/mobile/products/$id/barcode" { |
There was a problem hiding this comment.
There was a change request related to this endpoint in mobile repo
There was a problem hiding this comment.
grails-app/controllers/org/pih/warehouse/api/MobileProductApiController.groovy
Show resolved
Hide resolved
| return | ||
| } | ||
|
|
||
| if (oldUpc?.trim() == newUpc) { |
There was a problem hiding this comment.
Is this check needed? Do we care if there was an actual change or not?
There was a problem hiding this comment.
I'd say so - it prevents spamming the user with unnecessary emails and saves resources.
There was a problem hiding this comment.
@olewandowski1 The reason I asked was because I was not sure about i don't like status: 'no_change' approach (since this is not our convention in such cases, and is not idiomatic REST), and because I was not fully sure how we'd like to have it done instead (if it should be a 204 in this case or a 200 with additional info), I thought it is just not required now, and we can get rid of it for now and revisit later if needed. On the other hand, if you just don't want to send the notification, you could check this on the notification send level.
There was a problem hiding this comment.
Kk, makes sense to me now, I'll correct it
Link to GitHub issue or Jira ticket: https://openboxes.atlassian.net/browse/OBLS-284
Description: