Add docstrings to some python initializers #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 15845093273Details
💛 - Coveralls |
cattabiani
approved these changes
Jun 26, 2025
| }; | ||
| return py::class_<Population, std::shared_ptr<Population>>(m, clsName, docString) | ||
| .def(py::init<const std::string&, const std::string&, const std::string&>()) | ||
| .def(py::init([](py::object h5_filepath, py::object csv_filepath, std::string name) { |
Contributor
There was a problem hiding this comment.
I thought these methods did not need a docstring
Collaborator
Author
There was a problem hiding this comment.
I thought you wanted them :)
Contributor
There was a problem hiding this comment.
(I approved already :D)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Population::__init__CompartmentSets::from_fileto accept pathlibPath