compartment_set in BaseInput object
#12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Since Mike is away I need to ask other people for review :D |
ilkilic
reviewed
Aug 20, 2025
ilkilic
reviewed
Aug 20, 2025
ilkilic
reviewed
Aug 20, 2025
ilkilic
reviewed
Aug 20, 2025
ilkilic
reviewed
Aug 20, 2025
| })"; | ||
| CHECK_THROWS_WITH( | ||
| SimulationConfig(contents, "./"), | ||
| Catch::Matchers::Contains("node_set") && |
There was a problem hiding this comment.
should we use Catch::Matchers::AllOf(...) here instead of &&?
Contributor
Author
There was a problem hiding this comment.
we are still useing catch2 v2. It does not have AllOf
Pull Request Test Coverage Report for Build 17105736473Details
💛 - Coveralls |
ilkilic
approved these changes
Aug 21, 2025
ilkilic
left a comment
ilkilic
left a comment
There was a problem hiding this comment.
Thank you @cattabiani , looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Following openbraininstitute/sonata-extension#9 we need to add this functionality to libsonata. Here we are... with tests!
node_setorcompartment_setare necessary inInputBase. Both throw an errorSmaller Changes:
amp_startwas failing with aSonataErrorbut not because it was missingamp_start. In factspike_replayhas been removed and this test was not updated. I added a more strict version of this test.